BuilderReturnThis: Don't flag already annotated builder methods#40
Open
rickie wants to merge 1 commit into
Open
BuilderReturnThis: Don't flag already annotated builder methods#40rickie wants to merge 1 commit into
rickie wants to merge 1 commit into
Conversation
ibabiankou
approved these changes
Sep 23, 2022
ibabiankou
left a comment
ibabiankou
left a comment
There was a problem hiding this comment.
Thanks for picking it up right away 🚀
Member
Author
|
This is no longer an issue. Verified this with current |
Member
Author
|
I was wrong, this is still a problem (ran the wrong local repository build 😅). After all we didn't have that many violations or rewrote our code in such a way that we didn't need a suppression. Still, this exact case seems like a clear improvement. WDYT @Stephan202 ? |
Stephan202
force-pushed
the
rossendrijver/bugs/builder_return_this
branch
from
d3840ad to
4ff8187
Compare
Stephan202
approved these changes
Aug 6, 2023
Stephan202
left a comment
Stephan202
left a comment
Member
There was a problem hiding this comment.
I missed this question; sorry for the delay. Rebased the branch. I think this is a fair suggestion, though perhaps we can construct a suggested commit message that describes in which cases such a builder method is useful? (I forgot the relevant context.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's similar to the extra check in CanIgnoreReturnValueSuggester.