Repository navigation
Compile the fixture views before the browser server starts (1.x) - #3
Merged
Merged
Conversation
MoamenEltouny
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser tests intermittently failed on CI with a
RootTagMissingFromViewException: the fixture server runs several PHP workers, Blade writes a compiled view without a lock, and a worker that read it while another one was still writing it rendered an empty view. It only hit the first visit of a view on a cold cache, which is why it was always the first browser project and always a different test, on 2.x, 3.x, and 4.x code alike.tests/Browser/compile.phpnow compiles every fixture view beforephp -Sstarts, at the same paths the workers use, so the workers only read compiled views. The earlier fifteen-second wait is reverted: it only made the failure slower.Test tooling only; no release.