launcher: clone-fix + vllm-timeout + tpu-reset + skip-stage3 + no-auto-delete - #248
Merged
Conversation
…o-delete bundle of 5 fixes for tpu/launch_5seeds_tunix.sh hit during tonight's pipeline run: a) repo-clone check now tests ~/bohdi-lora/.git, not just the dir, so a pre-populated ~/bohdi-lora/checkpoints/... no longer skips clone and trips the next git fetch. aborts loudly if the dir exists without .git/ instead of silently clobbering. b) shell-side watchdog around each eval invocation. kills the eval with rc=124 after VLLM_WAIT_TIMEOUT (default 600s) without a Running vllm-tpu container, or rc=1 the moment a container is observed exited (logs ExitCode). overrides the killed-process signal exit so eval_fail_count tracking sees the right rc. c) cleanup_eval restarts the tpu-runtime container so chip state is reset between Stage-4 configs. previously the next config's vllm inherited dirty device state and failed to init. d) Stage 3 train invocation now skips when checkpoints/seed_<N>/orbax/ 250/_CHECKPOINT_METADATA exists locally (resumed from GCS). step 250 is the last reliably-complete save (300 is invalid per #242). e) cleanup() trap's delete_vm gated behind LAUNCHER_DELETE_VM_ON_EXIT, default off. successful runs no longer auto-destroy spot slots that we cannot get back due to TRC capacity contention. PREEMPTED retry path keeps deleting because preempted is terminal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle of 5 fixes for
tpu/launch_5seeds_tunix.shhit during tonight's pipeline run. All five touch the same file so they ship together to avoid merge conflicts.Changes
~/bohdi-lora/.gitinstead of just~/bohdi-lora. A pre-populated~/bohdi-lora/checkpoints/...no longer skips the clone and trips the nextgit fetchwithfatal: not a git repository. Aborts loudly if the dir exists without.git/instead of silently clobbering.eval_healthbench.pyinvocation. Kills the eval withrc=124afterVLLM_WAIT_TIMEOUT(default 600s) without a Running vllm-tpu container, orrc=1the moment a container is observed exited (logsExitCodefor postmortem). Override-rc file ensureseval_fail_countsees the right code instead of the killed-process signal exit (137/143).cleanup_evalnow restarts thetpu-runtimecontainer so chip state is reset between Stage-4 configs. Previously the next config's vllm inherited dirty device state and failed to init.checkpoints/seed_<N>/orbax/250/_CHECKPOINT_METADATAexists locally (resumed from GCS). Step 250 is the last reliably-complete save; step 300 is structurally invalid per PR exporter: fall back to earlier step on broken final checkpoint #242.cleanup()trap'sdelete_vmgated behindLAUNCHER_DELETE_VM_ON_EXIT, default off. Successful runs no longer auto-destroy spot slots we can't get back due to TRC capacity contention. The PREEMPTED retry path still deletes because preempted is terminal.Test plan
bash -n tpu/launch_5seeds_tunix.shshellcheck --severity=error tpu/launch_5seeds_tunix.shpython -m pytest tests/ -x -q(185 passed, 1 skipped)