[MAJOR] Refactor and simplify template project + bug fixes - #30
Merged
Conversation
- Retain only inherited runtime tests and externalize generic template-system conformance. - Stabilize project CMake and reusable workflows so tailoring no longer reconstructs either surface. - Simplify cleanup and ROS rollout while preserving wrapper, CUDA, packaging, and metadata contracts. - Document the v2 ownership boundary and validate CPU, CUDA/OptiX, ROS 2, release, and tailoring paths.
…factor-tests-ownership
- Adopt PEP 8 and Google-style documentation with static-ready typing. - Require Doxygen contracts for public C++ and CUDA APIs.
- Remove package-time version staging and recursive build-cache discovery. - Package the prepared source VERSION instead of post processing it.
- Add optional utility to manage tensorrt discovery and integration into project. - Update package config template cmake.in. - Update tests and documentation.
- Add handled TensorRT discovery, export, and tailoring guidance - Keep generic conformance in TestField and inherited runtime tests in v2 - Align wrapper packaging, build helpers, ROS metadata, and documentation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c843ba4b30
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Let find_dependency propagate the outer QUIET and REQUIRED modes - Allow optional consumers to report missing CUDA without a fatal error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the template into a leaner reusable C++/CUDA project while moving generic template-conformance ownership into the dedicated TestField repository. The resulting v2 architecture simplifies source packaging, strengthens generated-file and wrapper ownership, adds optional TensorRT integration, and synchronizes the release metadata at
v2.0.0.Main Changes
CMakeCache.txtdiscovery, copied helper templates, and recursive donor self-validation from the ordinary project test suiteHandleTensorRT.cmake,FindTensorRT.cmakediscovery module and export TensorRT as dependency for library installv2.0.0tag to the metadata-owning commitTesting / Validation
2.0.0metadata inVERSION, CMake, package filenames, and all ROS manifestsNotes For Reviewers
VerifyTemplateProject*product testsFindTensorRT.cmakeis the low-level discovery module, whileHandleTensorRT.cmakeowns the optional target/export integration policy