Bugfix/clean wrapper packaging safety (Codex gpt-5.6)

[PeterCalifano]

Summary

This follow-up records the final v1.12.1 scope and validation. The original packaging objectives remain unchanged, while the implementation was simplified, split by responsibility, and hardened against resolved filename collisions and source-archive races.

The signed v1.12.1 tag resolves to 480d10a692836040bcae2023e763c553acfcc64d.

Main Changes

• Split the former monolithic wrapper implementation into:
• HandleWrapper.cmake for public gtwrap orchestration;
• HandlePythonWrapper.cmake for Python targets and packaging;
• HandleMatlabWrapper.cmake for MATLAB handling;
• StagePythonRuntimeArtifacts.cmake for resolved-name validation and serialized staging.
• Resolve wrapper, runtime target-file, and SONAME filenames at build time instead of approximating them during configuration.
• Reject runtime/runtime, runtime/wrapper-extension, and target-file/SONAME collisions before copying any artifact, including configuration-dependent generator-expression output names.
• Keep Python wheel and CMake installations prefix-relative and loader-relative, while excluding checkout-only _wrapper_build.py metadata.
• Exclude active and cache-proven generated build trees from sourcearchives without dropping legitimate nested source, install, or foreign child-project content.
• Preserve all production wrapper modules through tailoring while keeping template-conformance verifiers template-owned for the v1.12.1 baseline.
• Synchronize all four ROS 2 package manifests with the final v1.12.1 release.

Testing / Validation

• Fresh template CPU build and complete CTest suite passed: 28/28.
• Fresh CUDA 12.9.41 build targeting sm_120 passed: 31/31.
• ROS 2 Jazzy built all four packages and passed 10/10 tests with no errors, failures, or skips.
• Focused Python packaging, source-release, clean-path ownership, tailoring, and tailored-project wrapper acceptance passed.
• Wheel and CMake-prefix installations imported with no checkout loader path and contained exactly the declared native artifacts.
• Collision rejection, incremental runtime refresh, loader-relative RUNPATH, metadata exclusion, shared/static packaging, install/export, and external-consumer checks passed.
• The aligned TestField v1.12.1 downstream acceptance passed:
  • CPU: 40/40;
  • CUDA: 41/41;
  • explicit OptiX: 17/17;
  • ROS 2: 10/10.
• Template branch/tag native, documentation, ROS 2, rollout-rehearsal, and tailored-project CI completed successfully.
• TestField main/tag native, documentation, and ROS 2 CI also completed successfully.
• CUDA CI remains intentionally skipped while the self-hosted runner is disabled; the corresponding local CUDA and OptiX matrices passed.
• ShellCheck, bash -n, Python byte-compilation, YAML/XML parsing, conflict-marker checks, git diff --check, and the CMake 3.15 API-floor audit passed.

Notes For Reviewers

• HandleWrapper.cmake is now a smaller public facade rather than the owner of every Python, MATLAB, and runtime-staging detail.
• Public wrapper options, including <namespace>_GTWRAP_RUNTIME_DEPENDENCY_TARGETS, remain supported. Private helper signatures and the previous configure-time filename analyzer are intentionally not preserved.
• Runtime declarations still accept direct project-owned SHARED_LIBRARY or MODULE_LIBRARY targets. Alias, imported, static, interface, and missing targets remain intentionally unsupported.
• _wrapper_build.py remains checkout-only metadata and is excluded from wheels and CMake installations.
• The v1.12.1 tag is the fixed correctness baseline. Moving template- system conformance ownership into the standalone TestField harness is a separate v2.0.0 refactor and is not part of this pull request.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2f21709791

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b277e4b84e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 480d10a692

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".