feat(web): graph view enhancements — larger drawer, node detail panel, toggleable legend, bigger cards (TASK-1787) - #724
Merged
Merged
Conversation
…, toggleable legend, bigger cards (TASK-1787) 1. Drawer opens wider — min(1500px, 94vw) — to take up the majority of the page. 2. Single-clicking a node selects it and opens a detail panel (ref, title, collection, status, terminal/child-count) with "Open item ↗" and "Focus here" (re-root) actions. Re-root/open are now explicit panel actions rather than bare-click behaviors, so a stray click can't navigate. 3. Legend entries are buttons that toggle a collection's visibility — hidden collections (and edges touching them) drop out via derived filters without recomputing the dagre layout, so positions stay stable. 4. Bigger node cards (212x60) showing up to two title lines; double-clicking a card zooms/centers on it. Parent: PLAN-1780 (follow-up). Drawer width lives in the item page; the rest in ItemGraph.svelte. Validated with svelte-check (0 errors) + build.
… per Codex review (round 1) - onPointerDown ignores presses that land on an interactive overlay (legend, detail card, error retry) via a target.closest check, so clicking those controls no longer begins a viewport drag / pointer capture. Avoids adding pointerdown handlers to static divs (keeps svelte a11y clean); detail card role dialog→group (no tabindex requirement, supports aria-label). - fitView now computes bounds from the currently VISIBLE nodes (falling back to full bounds when none visible), so Fit frames what's on screen after hiding collections instead of centering on invisible nodes. Parent: PLAN-1780.
…und 2) currentBounds() now returns null when no nodes are visible (instead of falling back to the full graph bounds), so fitView() — including the post-reroot queueFit — no-ops rather than recentering on the hidden graph. Removed the now dead full-graph bounds tracking (contentBounds + runLayout bounds computation). Parent: PLAN-1780.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four UX enhancements to the per-item dependency graph (PLAN-1780):
min(1500px, 94vw), taking up the majority of the page.Notes
ItemGraph.svelte.Test plan