Add godeps to revision lock cloudwatch library. - #2
Open
rpond-pa wants to merge 1 commit into
Open
Conversation
This change introduces `godep` to mark the dependencies on external libraries. To install `godep`: go get github.com/kr/godep To generate the initial Godeps file run: godep save -copy=false This creates a dependency JSON file. I edited the verison SHA's for two libraries: https://github.com/crowdmob/goamz/aws https://github.com/crowdmob/goamz/cloudwatch I set the SHA to this version: bfa553e3b7d6416a36cb81ff5f379acfb9b93f0d Using this SHA for the libaries, I was able to get the build to work with the following command: godep go build
|
Is this PR needed so that we can successfully build? What are the next steps on this one? There are no to-dos in the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces
godepto mark the dependencies on external libraries.To install
godep:To generate the initial Godeps file run:
This creates a dependency JSON file. I edited the verison SHA's for two libraries:
https://github.com/crowdmob/goamz/aws
https://github.com/crowdmob/goamz/cloudwatch
I set the SHA to this version:
bfa553e3b7d6416a36cb81ff5f379acfb9b93f0d
Using this SHA for the libaries, I was able to get the build to work with the following command: