Make sure motion parameters are reported in the same convention for tortoise and eddy - #1084
Open
mattcieslak wants to merge 1 commit into
Open
Make sure motion parameters are reported in the same convention for tortoise and eddy#1084mattcieslak wants to merge 1 commit into
mattcieslak wants to merge 1 commit into
Conversation
Motion confounds were reported in backend-specific frames: eddy/SHORELine via get_fsl_motion_params (FSL) and DIFFPREP via raw TORTOISE Okan params (LPS). Relative to the RAS world frame this flips trans_x/rot_x (eddy) and trans_x/trans_y/rot_x/rot_y (DIFFPREP), so the two backends disagreed and neither matched RAS-defined ground truth. Add get_ras_motion_params (per-volume ITK/LPS transform -> RAS, decomposed about the image center) and use it in CombineMotions (eddy/SHORELine); negate the x,y components of the DIFFPREP Okan params (LPS -> RAS). The confounds trans_*/rot_* columns are now RAS for every HMC backend. Add test_get_ras_motion_params_no_axis_flip, which verifies no axis flip on a radiological grid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have the diffprep backend for head motion/eddy current correction, I want to make sure that they're all reporting head motion parameters in the same coordinate convention. This PR makes both paths come out in RAS+ coordinates