Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
==========================================
- Coverage 47.41% 47.33% -0.08%
==========================================
Files 66 66
Lines 9888 9877 -11
Branches 1096 1096
==========================================
- Hits 4688 4675 -13
- Misses 4970 4973 +3
+ Partials 230 229 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR standardizes access to packaged static resources (JSON configs, LUTs, templates, etc.) by switching workflow/interface code from importlib.resources + as_path to the qsiprep.data loader (backed by acres), aligning QSIPrep with other BIDS Apps and addressing #904.
Changes:
- Replaced
importlib.resources.files(...)/as_path(...)resource lookups withqsiprep.data.load(...)across fieldmap, DWI, anatomical workflows, and an interface. - Updated CLI boilerplate/NOTICE loading to use
qsiprep.data. - Minor cleanup: removed a large commented-out block and modernized a string type check.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
qsiprep/workflows/fieldmap/unwarp.py |
Load ANTs registration settings via qsiprep.data.load. |
qsiprep/workflows/fieldmap/syn.py |
Load atlas and transform JSONs via qsiprep.data.load. |
qsiprep/workflows/fieldmap/pepolar.py |
Load ANTs translation/rigid settings via qsiprep.data.load. |
qsiprep/workflows/dwi/util.py |
Remove dead commented code; use isinstance(..., str) in _list_squeeze. |
qsiprep/workflows/dwi/registration.py |
Load intermodal ACPC registration settings via qsiprep.data.load. |
qsiprep/workflows/dwi/intramodal_template.py |
Load intramodal nonlinear settings via qsiprep.data.load. |
qsiprep/workflows/dwi/hmc.py |
Load SHORELine registration presets via qsiprep.data.load. |
qsiprep/workflows/dwi/fsl.py |
Load default eddy params via qsiprep.data.load. |
qsiprep/workflows/anatomical/volume.py |
Load FreeSurfer LUT/config, affine, identity transform, QuickSyN settings via qsiprep.data.load. |
qsiprep/interfaces/eddy.py |
Load b02b0_1.cnf via qsiprep.data.load when needed. |
qsiprep/cli/workflow.py |
Load NOTICE and boilerplate.bib via qsiprep.data.load. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes #904.