SIP390 Document units as they appear in input files - #392
Merged
Conversation
The units columns listed internal model units rather than what users put in the input files, with the actual input unit tucked into the notes. Climate file (src/sipnet/sipnet.c:216-224): - precip: cm -> mm - vpd, vpdSoil, vPress: kPa -> Pa - par: note the per-day conversion rather than restating the units column sipnet.param (src/sipnet/sipnet.c:1873-1902): - baseVegResp, litterBreakdownRate, baseSoilResp: day^-1 -> year^-1 - all nine rates that get divided by 365 now note the conversion the same way - the intro no longer claims all rates are per day Also note that event parameters take no unit conversion. Docs only; no change to model behavior or input formats.
priyanshusky0
requested review from
Alomir,
dlebauer,
mdietze and
mswilburn
as code owners
September 2, 2026 06:39
dlebauer
changed the title
dlebauer
reviewed
Sep 3, 2026
dlebauer
approved these changes
Sep 3, 2026
dlebauer
left a comment
dlebauer
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the contribution @priyanshusky0
dlebauer
enabled auto-merge (squash)
September 3, 2026 15:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #390
The units columns listed internal model units rather than the units used in the input files, with the actual input units tucked into the notes.
Climate file (
docs/user-guide/model-inputs.md)Per
src/sipnet/sipnet.c:216-224:precip: cm → mmvpd,vpdSoil,vPress: kPa → Papar: clarified the internal conversion instead of repeating the units columnsipnet.param(docs/parameters.md)Per
src/sipnet/sipnet.c:1873-1902:baseVegResp,litterBreakdownRate,baseSoilResp: day⁻¹ → year⁻¹Documentation only; no model behavior or input format changed.
Checklist
docs/CHANGELOG.mdupdated with noteworthy changesclang-format(rungit clang-formatif needed)Note: See CONTRIBUTING.md for additional guidance. This repository uses automated formatting checks; if the pre-commit hook blocks your commit, run
git clang-formatto format staged changes.