SIP370 Guard against negative mineral N - #374
Closed
Alomir wants to merge 46 commits into
Closed
Conversation
* Initial plan * Add unit tests for carbon accounting and plant mortality changes * Update for clang-format * Update context handling --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Mike Longfritz <Mike.Longfritz@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: dlebauer <464871+dlebauer@users.noreply.github.com>
Co-authored-by: dlebauer <464871+dlebauer@users.noreply.github.com>
…and-limitation-checks
…n-checks' into SIP370-Guard-Against-Negative-Min-N
…n-checks' into SIP370-Guard-Against-Negative-Min-N
Collaborator
Author
|
I'm going to close this in favor of creating a clean PR without all the baggage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
TBD
How was this change tested?
List steps taken to test this change, with appropriate outputs if applicable
If changes are needed for any
sipnet.outfiles in thetest/smokesubdirectories, then include output fromtools/smoke_check.pyby running the commands below and pasting the output at the end of this PR. Note thatthis must be run BEFORE submitting changes to any
sipnet.outfiles.Run
python tools/smoke_check.py helpfor more info.Reproduction steps
If appropriate, list steps to reproduce the change locally
Related issues
Checklist
docs/CHANGELOG.mdupdated with noteworthy changesclang-format(rungit clang-formatif needed)