Skip to content

SIP90 Add N loss to leaching - #178

Merged
dlebauer merged 54 commits into
masterfrom
SIP90-Add-N-loss-to-leaching
Nov 15, 2025
Merged

SIP90 Add N loss to leaching#178
dlebauer merged 54 commits into
masterfrom
SIP90-Add-N-loss-to-leaching

Conversation

@mswilburn

@mswilburn mswilburn commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Fixes #90

This PR:

  • Adds new param nLeachingFrac for leaching frac
  • Adds new flux nLeaching calc
  • Updates envi.minN with leaching loss
  • Adds test for N leaching (tests/sipnet/test_modeling/testNitrogenCycle.c)
  • Updates smoke tests, including the russell_2 smoke test

@mswilburn
mswilburn requested a review from dlebauer October 31, 2025 21:07
@mswilburn mswilburn changed the title SIP90 add n loss to leaching SIP90 add N loss to leaching Oct 31, 2025
@mswilburn mswilburn changed the title SIP90 add N loss to leaching SIP90 Add N loss to leaching Oct 31, 2025
@dlebauer

dlebauer commented Nov 7, 2025

Copy link
Copy Markdown
Member

@mswilburn can you please resolve conflicts before I review?

@mswilburn

Copy link
Copy Markdown
Contributor Author

@mswilburn can you please resolve conflicts before I review?

Yes, I'll work on that. Several things will need to change about this whole PR based on the discussion from today on how to handle leaching.

Base automatically changed from SIP89-Add-N-loss-to-volatilization to master November 12, 2025 19:32

@Alomir Alomir left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dlebauer dlebauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, congratulations on your first SIPNET PR! 🎉

(And thanks for creating ticket for associated documentation #185)

@dlebauer
dlebauer merged commit 5381ec1 into master Nov 15, 2025
11 checks passed
@dlebauer
dlebauer deleted the SIP90-Add-N-loss-to-leaching branch November 15, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add N loss to leaching

3 participants