Reorg for proper fluxes -> pools - #154
Merged
Merged
Conversation
Alomir
marked this pull request as ready for review
September 12, 2025 17:23
infotroph
approved these changes
Sep 17, 2025
infotroph
left a comment
infotroph
left a comment
Member
There was a problem hiding this comment.
Thank you! This seems much cleaner.
I left one nonblocking question on fn() vs fn(void)
Comment on lines
+138
to
+145
| void setupEvents(); | ||
|
|
||
| /*! | ||
| * Set all event fluxes to zero | ||
| * | ||
| * Reset all event fluxes to zero in preparation for the next climate step. | ||
| */ | ||
| void resetEventFluxes(void); |
Member
There was a problem hiding this comment.
Is setupEvents() instead of setupEvents(void) intentional here? I remember they have subtle differences but not how often they matter
Collaborator
Author
There was a problem hiding this comment.
I'm shocked that passed clang_tidy!
Collaborator
Author
There was a problem hiding this comment.
It shouldn't have, good catch. There's no actual difference, but leaving the parens empty is bad form.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reorganizes code to ensure proper fluxes-then-pools processing. No functional changes are made here.
soilDegradation, moving parts into different flux and pool functionsstate.cfileevents.c, now that the state definitions are out ofsipnet.c