Revise exudation parameter docs to use GPP - #153
Merged
Merged
Conversation
also, fix comments in N fert section
Alomir
reviewed
Sep 10, 2025
| | | 68 | fineRootExudation | fraction of GPP exuded to the soil[^exudates] | fraction | Pulsing parameters | | ||
| | 68 | | coarseRootExudation | fraction of GPP exuded to the soil[^exudates] | fraction | Pulsing parameters | | ||
|
|
||
| [^exudates]: Fine and coarse root exudation are calculated as a fraction of GPP, but the exudates are subtracted from the fine and coarse root pools, respectively. <!--Note that previous versions incorrectly defined fine root exudates as a fraction of NPP--> |
Collaborator
There was a problem hiding this comment.
The exudates factor in to the microbe model as well - do we want to note anything about that here?
Member
Author
There was a problem hiding this comment.
I think this part of the documentation (what is documented, notes on how it is calculated) applies equally to both.
I was just adding this note because the implementation was not intuitive.
I'm not sure what to add here, and I don't want to spend too much time documenting the microbe model until someone starts using it.
Alomir
reviewed
Sep 10, 2025
| - amount is listed as cm/d, but as events are specified per-day, this is treated as `cm` of water added on that day | ||
| - For method=soil, this amount of water is added directly to the `soilWater` state variable | ||
| - amount is listed as cm/d, as events are specified per-day, this is treated as `cm` of water added on that day even though it is added at a specific time step. | ||
| - For method=soil, this amount of water is added directly to the `soilWater` state variable. |
Collaborator
There was a problem hiding this comment.
This was correct - but now:
- moisture is added to fluxes.eventSoilWater, which is eventually added to soil moisture
- evaporation fraction is added to fluxes.eventEvap (still uses immedEvapFrac for calculating), which is added to the evapotranspiration tracker, reported in sipnet.out
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
and feel free to edit directly!
dlebauer
commented
Sep 10, 2025
Comment on lines
+522
to
524
| - amount is listed as cm/d, as events are specified per-day, this is treated as `cm` of water added on that day even though it is added at a specific time step. | ||
| - For method=soil, this amount of water is added directly to the `soilWater` state variable. | ||
| - For method=canopy, a fraction of the irrigation water (determined by input param `immedEvapFrac`) is added to the flux state variable `immedEvap`, with the remainder going to `soilWater`. |
Member
Author
There was a problem hiding this comment.
Suggested change
| - amount is listed as cm/d, as events are specified per-day, this is treated as `cm` of water added on that day even though it is added at a specific time step. | |
| - For method=soil, this amount of water is added directly to the `soilWater` state variable. | |
| - For method=canopy, a fraction of the irrigation water (determined by input param `immedEvapFrac`) is added to the flux state variable `immedEvap`, with the remainder going to `soilWater`. | |
| - The amount of irrigation is in units of cm per day, because events are specified per-day, but the entire irrigation is added in a single time step. | |
| - For `method=soil`, this amount of water is added directly to the soil water pool. | |
| - For `method=canopy`, a fraction of the irrigation flux is immediately evaporated (determined by input param `immedEvapFrac`, simulating canopy interception). This is added to the evaporation flux, and the remainder is added to the soil water pool. |
I removed the object names to convey the meaning without having to discuss the specific implementation. If anything, that would be better handled as inline comments or developer docs.
Collaborator
|
Merging this to make sure it gets into v2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was not intuitive and was incorrectly documented
also,