SIP132 Remove litterWater and clean up - #142
Merged
Merged
Conversation
Alomir
force-pushed
the
SIP132-Remove-litterWater
branch
from
August 21, 2025 19:27
6b2cd55 to
69c49fd
Compare
dlebauer
approved these changes
Aug 21, 2025
dlebauer
left a comment
Member
There was a problem hiding this comment.
This looks great. Only request is that we revisit whether we want to keep these obsolete cols (as discussed in slack). Though, that doesn't have to prevent merging this one.
Collaborator
Author
|
#145 for removal of obsolete columns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #132
This PR:
Note: we expect changes in the smoke tests; however, I did verify that the smoke tests still passed after the initial commit, wherein I collapsed
evapSoilFluxesandsoilWaterFluxesinto one function. That's commitf2f8d3b, which has a green check on it below.After the remaining code changes, I verified that the only output changes were in litterWater and fPAR; see smoke test results pre-submission:
smoke_res.txt
We WOULD expect more changes when LITTER_POOL is on, except that in that test case (
russell_3), we also have WATER_HRESP off, which sidesteps the code that would show such changes. We may want to revisit that config inrussell_3. (Note: @infotroph said that the soilWater values might match the now-removed litterWater values, which would also hide behavior changes)