Fix for __FILE_NAME__ in linux 22.04 - #133
Merged
Merged
Conversation
Alomir
marked this pull request as ready for review
July 23, 2025 19:29
Alomir
requested review from
dlebauer and
infotroph
and removed request for
dlebauer
July 25, 2025 15:28
infotroph
approved these changes
Jul 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently, R versions 4.1 - 4.3 rely on the 22.04 linux image instead of 24.04, and pecan is still using versions < 4.4 (I think? Henry was running into this issue getting the stack to compile in apptainer/docker). Turns out that sipnet cannot currently compile there due to the version of gcc that comes in that image (v11.x, where we need v12+). The issue is that the
__FILE_NAME__macro only got into gcc in version 12.From Henry: "the tie-in to R version is because the docker images are all based on rocker/tidyverse; and that stack switches to 24.04 starting in R4.4; <=R4.3 corresponds to 22.04"
This PR adds a workaround for that macro if it is not defined, as well as re-adding 22.04 to our CI image list to prevent such issues in the future.