Fix sparse indices and values, they are objects not arrays - #9
Open
victor-Lopez25 wants to merge 1 commit into
Open
Fix sparse indices and values, they are objects not arrays#9victor-Lopez25 wants to merge 1 commit into
victor-Lopez25 wants to merge 1 commit into
Conversation
Contributor
Author
|
There might be a similar fix needed in glb parsing but I haven't checked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm slowly doing the glTF 2.0 Khronos tutorial to render glTF and I found sparse accessors were not parsed correctly, so I fixed it. Here are the sources in the glTF 2.0 spec which say the sparse.indices and sparse.values are objects:
and here is the example I found was failing:
https://github.khronos.org/glTF-Tutorials/gltfTutorial/gltfTutorial_005_BuffersBufferViewsAccessors.html#sparse-accessors
I haven't gotten to rendering it yet though 😅 that might be a bit harder.