Handle incomplete session state in AcceptNotification and CompletePur… - #8
Merged
Merged
Conversation
daneastmond
reviewed
Apr 22, 2026
daneastmond
left a comment
daneastmond
left a comment
Collaborator
There was a problem hiding this comment.
Just flagging up that we're returning null for every status except 'complete'.
Are there any potential gotchas for actually failed transactions here?
AimalAzmi
force-pushed
the
handle-all-notification-status
branch
from
April 25, 2026 11:32
aef16da to
707301c
Compare
AimalAzmi
force-pushed
the
handle-all-notification-status
branch
from
April 25, 2026 12:17
707301c to
29b1ea5
Compare
daneastmond
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…chaseResponse