Skip to content

Fix primp impersonate BuilderError on client init - #1

Merged
Parveshiiii merged 1 commit into
Parveshiiii:mainfrom
sujalrajpoot:fix/primp-impersonate-error
Oct 25, 2026
Merged

Parveshiiii merged 1 commit into
Parveshiiii:mainfrom
sujalrajpoot:fix/primp-impersonate-error

Conversation

@sujalrajpoot

Copy link
Copy Markdown
Contributor

Description

Client() raised primp.BuilderError: Invalid impersonate: "chrome_114"
on some installs, so every Search().text(...) call failed.

  • Fall back to a client without impersonation if primp rejects the random
    profile, and log a warning.
  • Raise the minimum primp to 0.15.0. In my testing, 0.11-0.14 reject
    impersonate="random" and 0.10 and older lack impersonate_os, yet the
    old >=0.5.0 constraint allowed them.
  • Add a regression test and a changelog entry.

Environment: Windows, Python 3.13.

Traceback:
(paste your traceback here)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective
  • New and existing unit tests pass locally with my changes

@Parveshiiii
Parveshiiii merged commit 27144c5 into Parveshiiii:main Oct 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants