Feature: fastapi#11
Open
inventionpro wants to merge 2 commits into
Open
Conversation
Replaces Flask/waitress with Starlette/uvicorn behind a thin Flask-compat shim (app/router.py, app/compat.py, app/responses.py), so existing route bodies stay unchanged. Business logic stays synchronous and runs via Starlette's threadpool; the /stream SSE endpoint is upgraded to a real async asyncio.Queue + StreamingResponse so many long-lived connections don't rely on a thread-per-connection poll loop. Fixes a status-code bug in the compat shim where FileResponse status codes were never applied, which silently turned custom error pages (404.html, /pfp and /attachment 404s) into HTTP 200 responses.
Accept any non-expired channel key on message send instead of only the latest-by-seq key, so clients holding a still-valid older key aren't rejected with 'Invalid or outdated encryption key'. Guard key rotation to return the existing valid key instead of minting a duplicate, closing the race that produced coexisting valid keys. Clarify member-change key expiry comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.