Skip to content

fix(client): Authorization-Remote header casing #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gustavorps wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(client): Authorization-Remote header casing #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b7b3e6
fix(client): Authorization-Remote header casing
gustavorps Aug 10, 2026
7cbdb6f
test(client): assert Authorization-Remote header casing
gustavorps Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 43 additions & 8 deletions crates/client/src/http/collaboration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,16 @@ fn encode_basic_auth(username: &str, password: &str) -> String {
format!("Basic {}", encoded)
}

/// Returns the `(name, value)` pair for the remote-authentication header.
///
/// The TerminusDB server looks this header up **case-sensitively** — sending
/// `AUTHORIZATION_REMOTE` is silently ignored and the operation fails with an
/// auth error on v12. The exact casing below matches the server and the
/// JavaScript client.
fn authorization_remote_header(username: &str, password: &str) -> (&'static str, String) {
("Authorization-Remote", encode_basic_auth(username, password))
}

/// Collaboration operations for the TerminusDB HTTP client
impl super::client::TerminusDBHttpClient {
/// Fetches changes from a remote repository.
Expand Down Expand Up @@ -102,8 +112,8 @@ impl super::client::TerminusDBHttpClient {

// Add AUTHORIZATION_REMOTE header if credentials are provided
if let Some((username, password)) = remote_auth {
let auth_header = encode_basic_auth(username, password);
request = request.header("AUTHORIZATION_REMOTE", auth_header);
let (name, value) = authorization_remote_header(username, password);
request = request.header(name, value);
}

let body = json!({
Expand Down Expand Up @@ -220,8 +230,8 @@ impl super::client::TerminusDBHttpClient {

// Add AUTHORIZATION_REMOTE header if credentials are provided
if let Some((username, password)) = remote_auth {
let auth_header = encode_basic_auth(username, password);
request = request.header("AUTHORIZATION_REMOTE", auth_header);
let (name, value) = authorization_remote_header(username, password);
request = request.header(name, value);
}

// Apply timeout: use provided timeout or default to 15 minutes for incremental operations
Expand Down Expand Up @@ -343,8 +353,8 @@ impl super::client::TerminusDBHttpClient {

// Add AUTHORIZATION_REMOTE header if credentials are provided
if let Some((username, password)) = remote_auth {
let auth_header = encode_basic_auth(username, password);
request = request.header("AUTHORIZATION_REMOTE", auth_header);
let (name, value) = authorization_remote_header(username, password);
request = request.header(name, value);
}

// Apply timeout: use provided timeout or default to 15 minutes for incremental operations
Expand Down Expand Up @@ -467,8 +477,8 @@ impl super::client::TerminusDBHttpClient {

// Add AUTHORIZATION_REMOTE header if credentials are provided
if let Some((username, password)) = remote_auth {
let auth_header = encode_basic_auth(username, password);
request = request.header("AUTHORIZATION_REMOTE", auth_header);
let (name, value) = authorization_remote_header(username, password);
request = request.header(name, value);
}

// Apply timeout: use provided timeout or default to 1 hour for full database clone
Expand Down Expand Up @@ -509,3 +519,28 @@ impl super::client::TerminusDBHttpClient {
Ok(response)
}
}

#[cfg(test)]
mod tests {
use super::{authorization_remote_header, encode_basic_auth};

#[test]
fn authorization_remote_uses_server_exact_casing() {
let (name, _) = authorization_remote_header("admin", "root");
// The v12 server looks up this header case-sensitively; the previous
// ALL-CAPS form was silently ignored, breaking authenticated
// clone/push/pull between servers.
assert_eq!(name, "Authorization-Remote");
}

#[test]
fn authorization_remote_encodes_basic_credentials() {
let (_, value) = authorization_remote_header("admin", "root");
assert_eq!(value, "Basic YWRtaW46cm9vdA==");
}

#[test]
fn basic_auth_encodes_credentials() {
assert_eq!(encode_basic_auth("user", "pw"), "Basic dXNlcjpwdw==");
}
}