Return 404/409 on NoSuchJobError/DeserializationError to avoid improper 500 - #520
Open
jmadler wants to merge 3 commits into
Open
Return 404/409 on NoSuchJobError/DeserializationError to avoid improper 500#520jmadler wants to merge 3 commits into
jmadler wants to merge 3 commits into
Conversation
- Add blueprint error handlers: NoSuchJobError -> 404, DeserializationError -> 409 - delete_job_view: let NoSuchJobError propagate so handler returns 404 - README: document 404/409 behavior
Collaborator
|
@jmadler you will need to update the pr so we can check if it builds |
Collaborator
|
@jmadler we did not have any response back, we will wait for one more week and then close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Return 404/409 on NoSuchJobError/DeserializationError to avoid improper 500
Type of change
Checklist: