Add decoding for params from url - #376
Open
mastervolkov wants to merge 1 commit into
Open
Conversation
…assword with characters that require encoding.
Closed
|
Steps I used to run
See the error below; it looks like there was some work done around this function upstream here, which could have put this branch in a bad state. This branch should most likely needs a rebase to pick it up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If password on the redis server uses characters that require encoding in the URL ("?", "*"), then the decoding will not happen and the password will always be incorrect. Password encoding is always carried out, therefore, decoding should also always be done.