feat(updater): support custom HTTP headers via updater.conf#54
Open
ranganath42 wants to merge 2 commits into
Open
feat(updater): support custom HTTP headers via updater.conf#54ranganath42 wants to merge 2 commits into
ranganath42 wants to merge 2 commits into
Conversation
ranganath42
commented
Jul 24, 2026
| return nil, err | ||
| } | ||
| req.Header.Set("User-Agent", userAgent()) | ||
| // Legacy updater-profile.conf headers are set first so that |
Contributor
Author
There was a problem hiding this comment.
Here, the header priority is enforced purely by call order.
Reviewers, do you think we should make it a bit more robust by introducing a merge function instead of relying on order? Not trivial, but not a lot of rewrok either.
ranganath42
marked this pull request as ready for review
July 24, 2026 11:13
ranganath42
force-pushed
the
feat/custom-headers-via-file
branch
from
July 24, 2026 11:59
e9ab958 to
f19a98f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom HTTP headers via updater.conf
Adds an optional
updater.conffile next to the updater binary, letting operators attach custom HTTP headers (tenant IDs, routing tags, etc.) to update checks and downloads. No code changes needed per deployment.updater-profile.confheaders on collision, but cannot override headers describing the binary/host itself (User-Agent, OS headers, hop-by-hop headers).http.Get, no headers, no error status check).