test: make suite portable to Windows - #542
Closed
hellojiaru wants to merge 1 commit into
Closed
Conversation
hellojiaru
marked this pull request as ready for review
July 29, 2026 11:30
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shinstead of assuming/bin/shProblem
I ran the documented test workflow on Windows 11 at
b4d52c46c9113cb0f653d6df4cf71ebadf4930ac.The unmodified suite completed with:
The nine failures were test-environment assumptions rather than one runtime
bug:
/bin/shunconditionally;HOMEbut not WindowsUSERPROFILE;The current pytest workflow only runs Ubuntu, so this class of regression is
not visible before merge.
What changed
The patch keeps the security assertions intact:
symlinked credential paths;
skip instead of failing during setup;
shis available.The Windows job is intentionally limited to Python 3.12 to bound CI cost while
the existing Ubuntu job retains the Python 3.10–3.13 matrix.
Validation
Windows 11 build 26200, Python 3.12.3:
The total remains 428 collected tests.
git diff --checkalso passes.For transparency, the repository-wide Ruff command still reports 20 existing
findings in unrelated files; this patch does not claim to fix that baseline.
Boundaries
AI assistance
Codex helped structure the Windows failure analysis and prepare the patch. I
ran every command reported above locally, reviewed the diff, and take
responsibility for the proposed change and follow-up.