CI: run server tests without the pandablocks-dev-container - #95
Merged
Conversation
coretl
force-pushed
the
remove-test-dev-container
branch
2 times, most recently
from
June 29, 2026 11:16
e3b2977 to
d074e6d
Compare
coretl
force-pushed
the
remove-test-dev-container
branch
from
June 29, 2026 11:44
d074e6d to
51a7b37
Compare
The Python sim/test harness only needs numpy, now provisioned by uv (pyproject.toml + uv.lock, added in #92). Drop the pandablocks-dev-container image and run the regression tests on a plain ubuntu-latest runner. _test.yml: - run `make tests` under `uv run --locked` — the target depends on sim_server and then runs `make -C tests`; uv run puts the venv's `python`/`python3` (with numpy) on PATH for the `#!/usr/bin/env python` harness scripts and asserts uv.lock is in sync; - install valgrind (test_configs runs sim_server under valgrind, via simserver without -n); the container had provided it. The repo Dockerfile installs the same package so `make tests` behaves identically in the local dev container; - override BUILD_DIR to a workspace path (CONFIG.example pins the cross-build convention BUILD_DIR=/build/build-server, which the container gave as a volume); - add timeout-minutes so a stuck socket test can't run for hours. Make the test harness independent of the container's BusyBox nc (ubuntu ships netcat-openbsd, which does not close on stdin EOF without -N and would hang): - run_with_server: probe server readiness with bash /dev/tcp instead of `echo … | nc localhost 8888` in a loop — this loop was the CI hang; - simserver.in / tests/Makefile: bound the "force previous instance away" nc pokes with -w1. Dockerfile: add valgrind (mirrors the workflow apt install) so a developer running `make tests` in the dev container has the same tools as CI. Verified locally de-containerized: test_lut / test_exchange / test_extension pass; test_configs needs valgrind and is covered in CI. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
coretl
force-pushed
the
remove-test-dev-container
branch
from
June 29, 2026 11:47
51a7b37 to
f42c388
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Run the server regression tests without the
pandablocks-dev-containerimage — on aplain
ubuntu-latestrunner, with the Python harness provisioned by uv.Why
After #94 the Python sim/test harness is managed by uv (
pyproject.toml+uv.lock),and its only third-party dependency is numpy. So the dev-container is no longer
needed just to provide a Python-with-numpy environment for the tests.
How
_test.ymlnow:container:(and its/buildvolume mount), running directly onubuntu-latest;uv syncs, then activates the venv — itspython/python3carrynumpy, which the harness scripts need (they're
#!/usr/bin/env python);BUILD_DIRto a workspace path (CONFIG.examplepins the cross-buildconvention
BUILD_DIR=/build/build-server, which the container had provided as amounted volume).
makestays the runner; the C build (make sim_server,parse_lut_test) uses therunner's native toolchain.
Verification
Ran the full de-containerized flow locally —
make sim_serverthenmake -C tests(
test_lut,test_exchange,test_extension,test_configs) — passes (exit 0).🤖 Generated with Claude Code