Skip to content

Make Map and Array iteration methods public #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boukeversteegh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make Map and Array iteration methods public #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xee-interpreter/src/function/array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ impl Array {
self.0.get(index)
}

pub(crate) fn iter(&self) -> impl DoubleEndedIterator<Item = &sequence::Sequence> {
pub fn iter(&self) -> impl DoubleEndedIterator<Item = &sequence::Sequence> {
self.0.iter()
}

Expand Down Expand Up @@ -98,7 +98,7 @@ impl Array {
Some(Self::new(vec))
}

pub(crate) fn len(&self) -> usize {
pub fn len(&self) -> usize {
self.0.len()
}

Expand Down
8 changes: 4 additions & 4 deletions xee-interpreter/src/function/map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ impl Map {
Ok(Map::from_map(result))
}

pub(crate) fn len(&self) -> usize {
pub fn len(&self) -> usize {
match self {
Map::Empty(map) => map.len(),
Map::One(map) => map.len(),
Expand All @@ -85,21 +85,21 @@ impl Map {
Map::Many(map) => map.is_empty(),
}
}
pub(crate) fn get(&self, key: &atomic::Atomic) -> Option<&sequence::Sequence> {
pub fn get(&self, key: &atomic::Atomic) -> Option<&sequence::Sequence> {
match self {
Map::Empty(map) => map.get(key),
Map::One(map) => map.get(key),
Map::Many(map) => map.get(key),
}
}
pub(crate) fn keys(&self) -> Box<dyn Iterator<Item = &atomic::Atomic> + '_> {
pub fn keys(&self) -> Box<dyn Iterator<Item = &atomic::Atomic> + '_> {
match self {
Map::Empty(map) => Box::new(map.keys()),
Map::One(map) => Box::new(map.keys()),
Map::Many(map) => Box::new(map.keys()),
}
}
pub(crate) fn entries(
pub fn entries(
&self,
) -> Box<dyn Iterator<Item = (&atomic::Atomic, &sequence::Sequence)> + '_> {
match self {
Expand Down