Skip to content

feat:[PEA-2112] Tag flattening for AWS assets#185

Merged
arunpaladin merged 1 commit into
mainfrom
feat/tag-flattening-aws
Jul 14, 2026
Merged

feat:[PEA-2112] Tag flattening for AWS assets#185
arunpaladin merged 1 commit into
mainfrom
feat/tag-flattening-aws

Conversation

@nkeerthana111

@nkeerthana111 nkeerthana111 commented Jul 13, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Bug Fixes
    • Improved AWS asset processing to apply the same tagging and data-flattening behavior already supported for Azure assets.
    • Updated both new and legacy asset handling for more consistent AWS results.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ac7bb26d-ff19-4fbe-89f7-112d2a0ebe25

📥 Commits

Reviewing files that changed from the base of the PR and between fca92e3 and af0ef1b.

📒 Files selected for processing (1)
  • assets-management/services/svc-asset-delta-engine/src/main/java/com/paladincloud/common/assets/AssetDocumentHelper.java

📝 Walkthrough

Walkthrough

AssetDocumentHelper now applies Azure-specific tag flattening and secondary tag handling to AWS in both primary asset creation and primary asset update flows.

Changes

Asset tag handling

Layer / File(s) Summary
Extend provider-specific tag handling
assets-management/services/svc-asset-delta-engine/src/main/java/com/paladincloud/common/assets/AssetDocumentHelper.java
populateNewPrimary and updatePrimary now include "aws" alongside "azure" for flattened and secondary tag handling.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: kevin-paladin, arunpaladin

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: AWS assets now use the tag flattening behavior.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/tag-flattening-aws

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@arunpaladin arunpaladin merged commit 4cea3ba into main Jul 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants