Fly rando solaceon is weird - #4
Merged
Merged
Conversation
I am pretty sure something is broken with the required_fly_items_for_flight option, it seems like they are reversed. this gets this connection working, despite it being for the incorrect option
I am pretty sure something is wrong with require_fly_items_for_flight. if i name these correctly, the options are reversed when generating. I am changing these names for now so that they function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so flying to solaceon is a bit different, because it depends on your require_fly_item_for_flight option
If it is set to on: it functions like every other town
If set to off, every other town, and Solaceon_town don't need logic modifications, because if you can reach those on foot, you can do it again. solaceon_town_ledge however gets a connection to solaceon_town, so you can fly there without the required item, but only if you have $fly and opt_require_fly_item_for_flight_on
because of this one logical difference, i did add it to the settings popup (i figured out how to do it!)
In additon, I think the require_fly_item_for_flight option is mixed up somewhere. when testing with seeds generating, seeds set to On were being reported as Off, and vice versa. I've edited them here so that they work. I do not know where the fault actually is.
if this is completely the wrong line of thinking, please yell at me