Repository navigation
fix(core): fence task completion by execution generation - #118
Merged
Merged
Conversation
added 2 commits
October 29, 2026 08:06
A late executor result must not finish a newer run of the same task. Compare the observed durable run count atomically, negotiate server support, and use the precondition for all automatic completion paths. Verified real HTTP stale/current transitions, five real executor/restart scenarios, compatibility checks and SDK tours.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A delayed executor or scheduler could finish a task after another run of that task had started. Task completion now accepts expected_attempts_started and compares it, together with the optional retry limit, inside the state/audit transaction. Automatic completion, cancellation, history recovery and proposal-result completion use this execution snapshot.
The orchestrator negotiates tasks.finish_preconditions before using the operation; an older server cannot silently ignore its safety condition. A rejected transition drops local assumptions and reloads durable history. Ordinary explicit completion remains compatible. ADR0035, generated API/SDKs, README and roadmap are updated; no storage migration.
Validation: real HTTP red (stale completion accepted) → green (412, newer task preserved, matching completion accepted); five real-server/shell scheduler scenarios including a delayed old executor and newer active run (1.50s); capability refusal/zero-value serialization; SDK tours (12 TypeScript, 13 Python); Web typecheck. Previous policy/audit regression remains green. No test gate changed.