Skip to content

[Cherry-Pick][CI] Update approval check list- #79735 - #79736

Open
omoYang wants to merge 2 commits into
PaddlePaddle:release/3.4from
omoYang:cp-update-approval
Open

[Cherry-Pick][CI] Update approval check list- #79735#79736
omoYang wants to merge 2 commits into
PaddlePaddle:release/3.4from
omoYang:cp-update-approval

Conversation

@omoYang

@omoYang omoYang commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

PR Category

Environment Adaptation

PR Types

Others

Description

Update approval check list, replace luotao1 with wanghuancoder
devPR:#79735

是否引起精度变化

@Paddle-Bot Paddle-Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paddle-Bot Review Board (review完成)

序号 位置 优先级 规则来源 状态
1 常规 CI 绕过名单 P1 默认规则
2 发布分支关联 P2 默认规则

P2 Description 已补充 devPR:https://github.com/PaddlePaddle/Paddle/pull/79735,发布分支关联校验已通过。

Powered by Nyanpasu with gpt-5.6-sol 默认推理级别, please check the suggestions carefully.

contents: read
env:
CI_TEAM_MEMBERS: '["swgu98", "risemeup1", "xiaoguoguo626807", "luotao1"]'
CI_TEAM_MEMBERS: '["swgu98", "risemeup1", "xiaoguoguo626807", "wanghuancoder"]'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 这里只迁移了 slice 工作流的 bypass 成员,但常规 .github/workflows/check-bypass.yml:23 仍包含 luotao1 且不包含 wanghuancoder;该工作流目前被 Approval、CheckPRTemplate、Linux/Windows 等约 30 个工作流复用。因此大多数 CI 仍允许前者触发 skip-ci,而后者无法获得本次迁移后的同等权限。请同步更新这份常规 bypass 名单。

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已确认常规 bypass 名单已同步替换,两个工作流均不再包含旧账号,此问题已解决。

@omoYang omoYang changed the title [CI] Update approval check list- #79735 [Cherry-Pick][CI] Update approval check list- #79735 Sep 3, 2026

@wanghuancoder wanghuancoder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Paddle-Bot

Paddle-Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Failed CI看板

流水线名称 问题标签 修复建议 日志片段
Approval / Check approval 审批门禁未满足 【与当前改动有关】为修改旧 CI 脚本的 PR 获取 swgu98risemeup1 的 RD approval 后重新运行审批检查。 Job
CI-Windows / Windows-GPU / Build and test 编译缺少 static_op_function.h 【与当前改动无关】检查 Windows 构建中的头文件生成步骤和构建目录完整性,确认生成 paddle/fluid/pybind/static_op_function.h 后重新运行该 job。 Job
日志分析报告

失败的测试 case:

1. Check approval
   步骤:检查旧 CI 脚本修改所需的 RD approval。
   关键错误:必须有 swgu98 或 risemeup1 的 approval;当前检查发现 1 个 approved error,最终以 exit code 6 失败。

2. Windows-GPU / Build and test
   步骤:使用 MSVC、CUDA 12.0 编译 Paddle。
   失败位置:编译 paddle/fluid/pybind/ops_api.cc。
   关键错误:paddle/fluid/pybind/manual_static_op_function.h:33 无法找到
   paddle/fluid/pybind/static_op_function.h,错误码 C1083;随后 ninja 因子命令失败退出,最终 exit code 7。

根本原因分析:

两个 job 是相互独立的失败链路。

Check approval 失败与当前 PR 直接相关。PR 修改了 .github/workflows/check-bypass*.ymlci/check_approval.shci/coverage_build_size_approval.sh 等 CI 审批脚本,因此触发了旧 CI 脚本的特殊审批规则。日志明确要求 swgu98risemeup1 的 RD approval,当前审批状态不满足该要求。

Windows-GPU / Build and test 的直接根因是编译时缺少 paddle/fluid/pybind/static_op_function.h。当前 diff 没有修改该头文件、manual_static_op_function.h、相关代码生成逻辑或 CMake 配置;paddle/scripts/paddle_build.sh 中的改动也只是注释中的审批人名称。因此该编译失败与当前 PR 改动无直接关系。仅凭给出的日志片段无法进一步确定是头文件生成步骤跳过、生成失败,还是构建工作区缺少生成物。

修复建议:

  1. 【与当前改动有关】Check approval:邀请 swgu98risemeup1 对该旧 CI 脚本修改进行 RD approval,确认审批已被 GitHub 检查识别后重新运行 Check approval
  2. 【与当前改动无关】Windows-GPU / Build and test:检查构建前的代码生成日志,确认 static_op_function.h 是否生成到预期目录并位于编译器 include path 中;若生成步骤正常但文件缺失,清理并重新配置构建目录后重跑该 job。

Powered by Nyanpasu with gpt-5.6-luna 默认推理级别, please check the suggestions carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants