Skip to content

[release/3.4] Sync bot approval rules from #79714 - #79721

Open
liuhao2638 wants to merge 1 commit into
PaddlePaddle:release/3.4from
liuhao2638:codex/add-paddle-bot-approval-release-3.4
Open

[release/3.4] Sync bot approval rules from #79714#79721
liuhao2638 wants to merge 1 commit into
PaddlePaddle:release/3.4from
liuhao2638:codex/add-paddle-bot-approval-release-3.4

Conversation

@liuhao2638

@liuhao2638 liuhao2638 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

PR Category

Execute Infrastructure

PR Types

Devs

Description

同步 Paddle #79714 的 bot approval 与 CI Analyzer 改动到 release/3.4 分支。

  • 增加 Bot Approval Required workflow,按当前 head 的最新决定性 review 状态检查 risemeup1111Paddle-Bot 及人工审批账号。
  • 增加 CI Analyzer 默认规则。
  • release/3.4 已包含 AI review 基础规则 references/base-rules.md,本 PR 不重复添加。
  • workflow 仅由 PR openedsynchronizereopened 触发;review 状态变化不会单独触发本 workflow;机器人长时间无响应时可在 GitHub 评论区 @Paddle-Bot 重新触发。

Merged in dev: #79714

关联 PR

Paddle #79714

是否引起精度变化

否。本 PR 仅同步 GitHub Actions 和 CI 分析规则,不涉及框架代码,不引起精度变化。

@liuhao2638 liuhao2638 changed the title [release/3.4][CI] Sync bot approval gate and analyzer rules [release/3.4] Sync bot approval rules from #79714 Aug 31, 2026
@swgu98

swgu98 commented Aug 31, 2026

Copy link
Copy Markdown
Member

@ShigureNyako 来approve

@ShigureNyako ShigureNyako left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed current head 8a772fb974cd69f9de18fd1a2da153aca4bb23fd. The two added files are byte-identical to their final versions in merged PR #79714. I also verified compatibility with release/3.4's reusable check-bypass workflow, the current-head review filtering and bot/human approval OR logic, and the documented trigger policy.

Validation: git diff --check and bash -n on the embedded approval script passed; Codestyle-Check / Pre Commit is green. The remaining failed jobs are approval-state gates, not code regressions. No blocking issues found.

LGTMeow 🐾

@risemeup1111

risemeup1111 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Failed CI看板

流水线名称 问题标签 修复建议 日志片段
Bot Approval Required - Require review-bot approval 当前 head 未满足审批门禁 【与当前改动有关】让 risemeup1111Paddle-Bot,或 sneaxiy/From00 对当前 head 提交有效 APPROVED review,然后重跑该 workflow 报错代码
Approval - Check approval PR 审批/描述校验失败 【与当前改动无关】按 Approval workflow 要求补充一名 RD 审批,并修正 PR 描述格式后重跑 报错代码
Check PR Template - Check PR Category 解析值不合法 【与当前改动无关】按照目标分支的 PR 模板重新填写 PR Category,确保字段值为允许项并位于正确模板位置,然后重跑 报错代码
日志分析报告

失败的测试 case:

1. Require review-bot approval
   步骤:Verify approval status
   关键错误:当前 HEAD_SHA=8a772fb974cd69f9de18fd1a2da153aca4bb23fd 上,没有 REQUIRED_BOT_LOGINS 或 APPROVERS 的最新决定性 APPROVED 状态。
   退出码:1

2. Check approval
   步骤:Approval 检查
   关键错误:Not recommended to use Chinese;必须有 swgu98、zhangbo9674 或 risemeup1 中一名 RD 审批;共发现 2 个 approval errors。
   退出码:6

3. Check PR Template
   步骤:check_pr_template
   关键错误:PR Category 被解析为“develop 上已合并的 #79714 到 release/3.4 ...”,不属于允许的 PR Category 列表。
   退出码:7

根本原因分析:

  1. Require review-bot approval 是本 PR 新增的 workflow。日志显示 GitHub API 请求和 jq 处理均完成,随后进入“尚未通过 approve”的明确失败分支,说明当前 head 没有满足 OR 条件的机器人或人工审批。这是新增审批门禁的预期阻断行为,没有证据表明 runner、网络或脚本执行异常。

  2. Check approval 的可见错误是 PR 审批规则未满足,且日志还显示存在另一项 approval error。PR diff 未修改该审批检查器、审批名单或其执行入口,因此不能归因于本次代码改动。该 job 与审批门禁 job 是并行独立检查,不是由 job 1 的退出码级联产生。

  3. Check PR Template 明确报告 check_pr_template: False,失败原因是校验器读取到的 PR Category 值不在允许列表中。PR diff 只新增 CI Analyzer skill 和 bot approval workflow,没有修改 PR 模板或模板校验代码,因此这是 PR 描述格式/内容问题,与本次代码改动无直接关联。

修复建议:

  1. 【与当前改动有关】Require review-bot approval:针对精确 head 8a772fb974cd69f9de18fd1a2da153aca4bb23fd 获取机器人或指定人工账号的 APPROVED review,并重新运行该 workflow;新提交后需重新审批当前 head。

  2. 【与当前改动无关】Check approval:修正 PR 描述中的格式问题,补充规则要求的 RD 审批,并重跑 Approval

  3. 【与当前改动无关】Check PR Template:按 release/3.4 使用的 PR 模板重新填写分类字段,确认 PR Category 是合法枚举值且未被后续描述文本吞并,再重跑 Check PR Template

Powered by Nyanpasu with gpt-5.6-luna 默认推理级别, please check the suggestions carefully.

@liuhao2638

Copy link
Copy Markdown
Contributor Author

/rerun all-failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants