[Build] Avoid FlashAttention v3 for sm100 builds#79500
Merged
Merged
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
risemeup1111
suggested changes
Jul 17, 2026
risemeup1111
left a comment
Contributor
There was a problem hiding this comment.
发现一处需要修复后再合入的构建条件问题,细节已放在行级评论中。PR 标题和描述基本匹配变更;当前仍有部分 CI 任务在运行,本次结论主要基于代码审查。
Powered by Nyanpasu with gpt-5.5 xhigh, please check the suggestions carefully.
risemeup1111
suggested changes
Jul 17, 2026
risemeup1111
left a comment
Contributor
There was a problem hiding this comment.
已复查,作者在旧线程里的反馈是成立的:上一版建议会让全架构构建不再编译 FAv3。当前 head 仍需要修正这一点,具体修改建议已放在新的行级评论中。
Powered by Nyanpasu with gpt-5.5 xhigh, please check the suggestions carefully.
Co-authored-by: risemeup1111 <13125134909@163.com>
risemeup1111
approved these changes
Jul 17, 2026
risemeup1111
left a comment
Contributor
There was a problem hiding this comment.
已复查,上一轮关于全架构包的顾虑已在当前提交中修正,未发现新的阻塞问题。
Powered by Nyanpasu with gpt-5.5 xhigh, please check the suggestions carefully.
SigureMo
approved these changes
Jul 17, 2026
SigureMo
pushed a commit
to risemeup1111/Paddle
that referenced
this pull request
Jul 17, 2026
--------- Co-authored-by: risemeup1111 <13125134909@163.com>
sneaxiy
pushed a commit
that referenced
this pull request
Jul 20, 2026
#79500) (#79496) * [Build] Compile FlashAttention on arm64 platforms (#79488) --------- Co-authored-by: Claude <noreply@anthropic.com> * [Build] Avoid FlashAttention v3 for sm100 builds (#79500) --------- Co-authored-by: risemeup1111 <13125134909@163.com> --------- Co-authored-by: liuhao2638 <2284903223@qq.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Environment Adaptation
PR Types
Bug fixes
Description
在 CUDA 12.3 到 13.0 的构建配置中,FlashAttention v3 原先对所有
CUDA_ARCH_BIN >= 90的架构启用。对于CUDA_ARCH_BIN=100,这会额外触发 v3 的sm90实例化编译,而该路径在 ARM64 + CUDA 13 环境中可能出现 nvcc 编译段错误。本次修改将 v3 的启用条件收窄到
CUDA_ARCH_BIN == 90。这样编译 100 架构时不会启用 FlashAttention v3,但仍会通过后续CUDA_ARCH_BIN >= 80分支编译 v2 FlashAttention。已执行检查:
pre-commit run --files cmake/third_party.cmakepre-commit run --from-ref origin/develop --to-ref HEADgit diff --check -- cmake/third_party.cmake是否引起精度变化
否。该修改仅调整 FlashAttention v3 的构建开关条件,不修改算子实现或数值计算逻辑。