[API Compatibility] change prefix matcher for 4 distributed apis -part#879
Merged
zhwesky2010 merged 7 commits intoJul 15, 2026
Merged
Conversation
|
Thanks for your contribution! |
…oup and torch.distributed.group.WORLD
Manfredss
changed the title
…to ApiEnhance_all_gather_object
zhwesky2010
reviewed
Jul 10, 2026
| g = torch.distributed.group.WORLD | ||
| """ | ||
| ) | ||
| expect = textwrap.dedent( |
Collaborator
There was a problem hiding this comment.
注意检查下AI的代码，单测是否真正运行了？是否符合规范？
distributed系列单测统一放到tests/distributed目录下
…to ApiEnhance_all_gather_object
zhwesky2010
reviewed
Jul 14, 2026
| rank = dist.get_rank() | ||
| torch.cuda.set_device(rank) | ||
|
|
||
| result = dist.get_rank(dist.group.WORLD) |
Collaborator
There was a problem hiding this comment.
result = dist.group.WORLD
| rank = dist.get_rank() | ||
| torch.cuda.set_device(rank) | ||
|
|
||
| print(dist.ProcessGroup) |
| obj = APIBase("torch.distributed.group.WORLD") | ||
|
|
||
|
|
||
| def test_case_1(): |
Collaborator
There was a problem hiding this comment.
这几个测试可以删除了，分布式统一在distributed中进行测试
zhwesky2010
reviewed
Jul 15, 2026
| rank = dist.get_rank() | ||
| torch.cuda.set_device(rank) | ||
|
|
||
| pg = dist.group.WORLD |
Collaborator
There was a problem hiding this comment.
这个测试没有调用dist.ProcessGroup？先合入了，后面顺带优化下吧。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Docs
torch.distributed.all_gather_object
torch.distributed.group.WORLD
torch.distributed.init_process_group
torch.distributed.ProcessGroup
PR APIs
related PR: