fix: add missing deploy key fields to DynamoDB schema (#514)#526
Open
dennismdejong wants to merge 1 commit into
Open
fix: add missing deploy key fields to DynamoDB schema (#514)#526dennismdejong wants to merge 1 commit into
dennismdejong wants to merge 1 commit into
Conversation
The DeployKey table schema in DynamoDB was only persisting 3 of 9 fields: id, key, and createdAt. Fields resourceType, scope, source, namespace, provider, name, and type were silently dropped because they were not registered in the enhanced client schema builder. Also added missing setters to DeployKey model for deserialization. Fixes PacoVK#514
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #514
The DeployKey table schema in DynamoDB was only persisting 3 of 9 fields: id, key, and createdAt. Fields resourceType, scope, source, namespace, provider, name, and type were silently dropped because they were not registered in the enhanced client schema builder. Also added missing setters to DeployKey model for deserialization.