Redesign the Comparison page into an anonymous financial mirror - #56
Merged
Conversation
…a new by-country view Replace the dense always-visible stat grids and dead legacy-rankings/motivational-popup code with a narrative, progressive-disclosure layout: a percentile gauge and plain-language headline insight up front, everything else tucked behind an accordion. Add a compare-by-country view built on the existing custom-cohort endpoint, and a Region & city placeholder with a clear roadmap toward a future clickable map and location/job change simulator. All underlying percentile/cohort/privacy logic is unchanged.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… redesigned Comparison page Custom comparison cohorts now broaden themselves when the exact requested factor combination has too few matches, dropping household then life stage then career while never touching geography, and always tell the user which factors the result actually used. The main comparison also shows a running "X of N people so far" count while the community is still small. The public demo account previously hit the opt-in wall and, for the factor customizer, "compare by country" and behaviour sections, called endpoints that don't exist without a real backend. It now ships with consent already granted, realistic cohort/population numbers, and mocked responses for those endpoints - including a demo-only preview of the new relaxation behavior.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Leaderboardimport,renderLegacyRankingsTab, motivational popup) along the way.locationfactor isolated — no backend changes needed — plus a "Region & city" placeholder that's honest about not collecting that data yet.MIN_COHORT,benchmark_consent, andgetBenchmarkOptInCopy) is unchanged — this is a presentation-layer rewrite.comparison.*i18n keys across all 6 locales, remove translation keys that became orphaned once the dead code was dropped, and extendtodo.md/roadmap with the geographic-comparison follow-ups (region/city profile field, clickable map, location/job change simulator).Test plan
npm run lint— 0 errors (121 pre-existing warnings elsewhere, none in touched files)npm test— 105 files / 1783 tests passed, includingComparison.optInCopy.test.js,translationCompleteness.test.js,translationUnusedKeys.test.jsnpm run build— succeeds🤖 Generated with Claude Code