Fix white-on-white filters, restyle edit modal, widen insert-values on desktop - #54
Merged
Merged
Conversation
…modal, and widen insert-values on desktop The shared FilterRow/FilterInlineRow components weren't receiving the theme prop they need to color their own note/date inputs and nested selects, rendering as unreadable white-on-white boxes in dark mode wherever filter panels are used (Outflows, Incomes, Shared Expenses). The transaction-edit modal's fields still carried the old inline-edit blue-border styling, which no longer made sense once they moved into a modal - switched to the app's standard neutral field style and dropped the now-redundant cancel button next to the modal's own close (X) button. insert-values was also capped at 1100px wide, forcing the transaction table to horizontally scroll even with plenty of unused space on a desktop window - widened to 1400px and let the table fill its container instead of capping at 1200px on its own.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes from live-testing #53's modal and mobile-table changes.
FilterRow/FilterInlineRowcomponents (used by every Outflows/Incomes/Shared-Expenses filter panel) weren't receiving thethemeprop they need to color their own note/date<input>s and any nested<select>- rendering as plain unthemed white boxes with unreadable white-on-white text in dark mode. Fixed everywhere this pattern occurred (10 call sites across Outflows, Incomes, and the new Shared Expenses filter panel).Test plan
npm run lint- 0 errorsnpm test- 105 files / 1783 tests passingnpm run build- production build succeeds🤖 Generated with Claude Code