Add some timed actions documentation - #3
Conversation
|
This looks good to me—out of curiosity, why is |
|
It's not related to the new network model so it didn't fit there: it's also an optional function that the base class doesn't implement but it felt really excessive to define one function as a helper class. Thinking on it now, it's probably not great as it'll make the typings for the vanilla classes inaccurate, this is a really annoying habit in the timed action code 😓 I'm not sure now how to go about documenting these optional functions without impacting accuracy, maybe tiny helper classes are the only way. We can just remove it for now if necessary. |
|
I handled some of the optional methods in |
Adds notes to some timed action methods, focused around networking. This adds the helper class
umbrella.NetworkedTimedAction: it would be cool to auto-assign this as a base class to networked vanilla actions by searching forcomplete()methods, but as is it's already helpful for user code to subclass.