Standardize buttons and minor fixes - #43
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes button components across the application by introducing a reusable Button component and consolidating button styles, along with a minor bug fix for transcription progress capping.
Key Changes
- Introduced a new
Buttoncomponent with variants (primary, danger, secondary, icon, ghost), sizes, loading states, and TypeScript type safety for icon-only buttons requiringaria-label - Replaced all custom button implementations across the codebase with the standardized
Buttoncomponent - Consolidated and removed duplicate button CSS from individual component stylesheets
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/components/ui/Button/Button.tsx | New reusable Button component with type-safe props |
| src/renderer/components/ui/Button/Button.css | Comprehensive button styles with variants and states |
| src/renderer/components/ui/Button/tests/Button.test.tsx | Test coverage for the Button component |
| src/renderer/components/ui/Button/index.ts | Export file for Button component |
| src/renderer/components/ui/index.ts | Added Button to UI components exports |
| src/renderer/index.css | Added global spin animation for reusability |
| src/renderer/App.css | Removed redundant button styles now handled by Button component |
| src/renderer/features/transcription/components/TranscriptionToolbar/TranscriptionToolbar.tsx | Migrated to use Button component |
| src/renderer/features/transcription/components/TranscriptionToolbar/TranscriptionToolbar.css | Removed button-specific styles |
| src/renderer/features/transcription/components/TranscriptionSearch/TranscriptionSearch.tsx | Migrated to use Button component |
| src/renderer/features/transcription/components/TranscriptionSearch/TranscriptionSearch.css | Removed button-specific styles |
| src/renderer/features/transcription/components/FileDropZone/FileDropZone.tsx | Migrated to use Button component |
| src/renderer/features/settings/components/ModelDetails/ModelDetails.tsx | Migrated to use Button component |
| src/renderer/features/settings/components/ModelDetails/ModelDetails.css | Removed button-specific styles |
| src/renderer/features/history/components/TranscriptionHistory/TranscriptionHistory.tsx | Migrated to use Button component |
| src/renderer/features/history/components/TranscriptionHistory/TranscriptionHistory.css | Removed button-specific styles |
| src/renderer/features/auto-update/components/UpdateNotification/UpdateNotification.tsx | Migrated to use Button component |
| src/renderer/features/auto-update/components/UpdateNotification/UpdateNotification.css | Removed button-specific styles |
| src/renderer/components/ui/SystemWarning/SystemWarning.tsx | Migrated to use Button component with loading state |
| src/renderer/components/ui/SystemWarning/SystemWarning.css | Removed button-specific and spin animation styles |
| src/renderer/components/ui/ErrorBoundary/ErrorBoundary.tsx | Migrated to use Button component |
| src/renderer/components/ui/ErrorBoundary/ErrorBoundary.css | Removed button-specific styles |
| src/renderer/components/ui/DebugLogsModal/DebugLogsModal.tsx | Migrated to use Button component |
| src/renderer/components/ui/DebugLogsModal/DebugLogsModal.css | Removed button-specific styles |
| src/renderer/components/layout/LeftPanel/TranscriptionActions/TranscriptionActions.tsx | Migrated to use Button component with loading prop |
| src/renderer/components/layout/LeftPanel/DonationSection/DonationSection.tsx | Migrated to use Button component |
| src/renderer/components/layout/AppHeader/AppHeader.tsx | Migrated to use Button component |
| src/main/services/whisper.ts | Fixed progress percentage capping at 100% |
| docs/styles.css | Removed button styles (affecting docs/index.html) |
| docs/privacy.html | Updated navigation structure to semantic HTML5 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 1.7.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.