tests: realign stale AVS fixtures with resolved-M CUBE contracts - #319
Merged
Merged
Conversation
Nine mainline AVS regressions tracked in #318 are stale test fixtures, not model regressions: - tile-fault-cube-location-003 used a exactly-sufficient 512B CUBE allocation as its undersized negative case. - tile-exec-tnot-cube-m16-m32-001 asserted a non-pure func call directly (TE_SEV). - block-bound-bstart-tmatmul-bias-shape-001 and tile-bound-matrix-bias-001 discarded ConfigureCubeTile results (TE_BC). - block-exec-bstart-tmatmul-bias-shared-001, tile-exec-matmul-001, and tile-exec-physical-accumulator-classes-001 kept RowMajor bias / accumulator fixtures that violate the resolved-M CUBE layout contract (ADR-CUBE-0006 amendment). - tile-bound-matrix-source-001 relied on the retired TileLocation discriminator for its negative case; a CUBE-layout source is the current rejection carrier. - tile-bound-tfma-datr-001 predates the intentional TFMA allowed_nonzero_fields Layout addition (PTO-TFMA-CONTRACT-001). All nine tests pass under PTO_ASLREF_ROOT AVS reruns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change contract
tests/870fc705549961263cc3872b92e40217a83b177f2486822ee773692e845d187d9d893a50d37dc4daNormative delta
No architecture-visible behavior changes. This realigns nine stale AVS fixtures with already accepted resolved-M CUBE layout, TFMA DATR applicability, CUBE allocation-size, and ASL sequencing contracts.
Agent review
/root/review_pr318_exactscripts/prepare-pr --base origin/main --head HEAD --review build/pr-review-318.jsonpassed for the exact reviewed headProjections and focused evidence
make pr-check(11 checks passed)git diff --checkRelease boundary
Release impact and known gaps: no release verification is required for this tests-only fixture correction. No known gaps remain for the nine repaired points.
Fixes #318