Skip to content

fix: separate ADR baseline from landing provenance - #242

Merged
zhoubot merged 1 commit into
mainfrom
codex/fix-adr-baseline-provenance
Sep 4, 2026
Merged

fix: separate ADR baseline from landing provenance#242
zhoubot merged 1 commit into
mainfrom
codex/fix-adr-baseline-provenance

Conversation

@zhoubot

@zhoubot zhoubot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • validate an ADR decision baseline as an existing commit that is an ancestor of its first-landing parent
  • validate new, uncommitted ADR baselines against the current branch head while landing provenance remains pending
  • distinguish an uncommitted ADR from a root-commit landing and require exactly one landing parent under linear history
  • preserve legacy-path provenance and reject missing, unrelated, or post-landing baselines
  • document the distinction between decision baseline and Git landing history

Motivation

The previous checker required baseline == first-landing parent, conflating a stable design/release baseline with a separate Git history fact. That rejected valid older ancestor baselines and made new uncommitted ADRs fail before a first landing could exist.

This is a governance/tooling correction only. It does not alter PTO ISA semantics or any ADR metadata.

Validation

  • python3 -m unittest tests/scripts/test_adrs.py — 61/61 PASS
  • modified checker against PR feat: retire software-replaceable tile operations #241 exact head d26c1efc34de13c689ab7f8ab2c0cae34f9693bd — 106 ADRs PASS
  • make pr-check — 9/9 PASS
  • make repo-check — 7/7 PASS
  • git diff --check — PASS

@zhoubot
zhoubot force-pushed the codex/fix-adr-baseline-provenance branch from 8a2b552 to 7869371 Compare September 4, 2026 06:03
@zhoubot
zhoubot merged commit c306794 into main Sep 4, 2026
4 checks passed
@zhoubot
zhoubot deleted the codex/fix-adr-baseline-provenance branch September 4, 2026 06:18
zhoubot added a commit that referenced this pull request Sep 4, 2026
## Summary\n\n- rebase the eight-operation retirement onto current main
0ae8eef\n- preserve the later InternalAcc, MSCATTER.POPC,
reference-power, and site dependency changes\n- retire TCONCAT,
TEXTRACT, TINSERT, THISTOGRAM, TQUANT, TDEQUANT, TSORT, and TMRGSORT
from active ASL, catalogs, documentation, numeric inventories, and
AVS\n- bind the retirement to publication 0.58.5.1 and preserve
historical numeric decisions; the now-obsolete draft ADR-NUM-0020 is
superseded\n- allocate non-conflicting legacy migration identity
ADR-0114; ADR-0112 is already owned by ADR-CUBE-0018\n- remove the
obsolete ADR provenance-gap note because #242 fixed the checker\n\n##
Repairs made during rebase\n\n- remove stale scalar1 and destination1
operand-enum references\n- remove the deleted quantization schema
call\n- remove retired numeric hooks, active numeric operations, and
conformance domains\n- refresh current inventory tests from 126 to 118
Tile operations and 86 to 78 TEPL selectors\n- make the retired-encoding
AVS valid ASL and link it to PTO-ARCH-ENCODING-OWNERSHIP-001\n\n##
Validation\n\n- PR source validation: PASS, 8/8\n- make repo-check:
PASS, 7/7\n- focused ASL: PASS, 6/6 (retired encodings plus GM atom/red,
GMOV, TMOV, TSHUF, TCVT/status)\n- focused repository/tooling regression
set: PASS, 119 tests\n- release selection blockers: empty\n- git diff
--check: PASS\n\n## Remaining blocker\n\nThe new encoding projection is
b365bb85c47dfaaeb6a3225bf60175694b3cdf5d887951ab43ee1e36a8c21e48, while
scripts/run-model-closure still records the previously approved
747c509525579dc84038738c9a3ba26ae6ed4ef29a1d302cefb2a7b07fc150a8
closure. Full tooling therefore has exactly one expected failure in
test_release_closure. Do not update the approved projection constant or
merge this PR until LLVM and ASL-MODEL have produced fresh exact-head
closure evidence for the new projection.

Co-authored-by: zhoubot <637081+zhoubot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant