Skip to content

ci: publish the web docs once per release - #6168

Merged
max-sixty merged 1 commit into
mainfrom
web-deploy-single-trigger
Aug 9, 2026
Merged

ci: publish the web docs once per release#6168
max-sixty merged 1 commit into
mainfrom
web-deploy-single-trigger

Conversation

@max-sixty

Copy link
Copy Markdown
Member

publish-web ran twice per release: once on the release event, once on the push to web that the release itself makes. The comment justifying the release: trigger says that push can't start a workflow, which holds for the default GITHUB_TOKEN but not here — release.yaml's push-web-branch job checks out with TEND_BOT_TOKEN, and a push made with a PAT starts workflows normally.

The run history since 0.13.10 shows both firing, minutes apart:

2026-07-24T14:45  push     web       success
2026-07-24T14:41  release  0.13.14   success
2026-06-14T18:30  push     web       success
2026-06-14T18:29  release  0.13.13   success

Releases 0.13.5 through 0.13.9 show only the release run, so the doubling dates from when that push started using the bot's PAT.

The web push run lands second, so it already decides what's published; the release-triggered run is overwritten a few minutes later. Keeping the push trigger rather than the release one also preserves republishing when a docs fix is backported to web outside a release.

What this gives up: the release-triggered run is an accidental fallback today, so if push-web-branch ever fails, no deploy happens at all rather than one from the tag. That failure is visible in the release run either way.

Now that github-pages requires a deployment approval, the redundant run also costs an approval per release.

This was written by Claude Code on behalf of max-sixty

A release triggered `publish-web` twice: on the `release` event, and on the push to `web` the release itself makes. The comment behind the `release:` trigger says a push cannot start a workflow, which is true of the default GITHUB_TOKEN but not of `push-web-branch`, which pushes with TEND_BOT_TOKEN.

The `web` push run lands second and already decides what is published, so the release-triggered run only repeats work — and, now that `github-pages` requires approval, costs an extra approval.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@max-sixty
max-sixty merged commit 772dec8 into main Aug 9, 2026
43 checks passed
@max-sixty
max-sixty deleted the web-deploy-single-trigger branch August 9, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants