ci: publish the web docs once per release - #6168
Merged
Merged
Conversation
A release triggered `publish-web` twice: on the `release` event, and on the push to `web` the release itself makes. The comment behind the `release:` trigger says a push cannot start a workflow, which is true of the default GITHUB_TOKEN but not of `push-web-branch`, which pushes with TEND_BOT_TOKEN. The `web` push run lands second and already decides what is published, so the release-triggered run only repeats work — and, now that `github-pages` requires approval, costs an extra approval. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
prql-bot
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publish-webran twice per release: once on thereleaseevent, once on the push towebthat the release itself makes. The comment justifying therelease:trigger says that push can't start a workflow, which holds for the defaultGITHUB_TOKENbut not here —release.yaml'spush-web-branchjob checks out withTEND_BOT_TOKEN, and a push made with a PAT starts workflows normally.The run history since 0.13.10 shows both firing, minutes apart:
Releases 0.13.5 through 0.13.9 show only the
releaserun, so the doubling dates from when that push started using the bot's PAT.The
webpush run lands second, so it already decides what's published; the release-triggered run is overwritten a few minutes later. Keeping the push trigger rather than the release one also preserves republishing when a docs fix is backported toweboutside a release.What this gives up: the release-triggered run is an accidental fallback today, so if
push-web-branchever fails, no deploy happens at all rather than one from the tag. That failure is visible in the release run either way.Now that
github-pagesrequires a deployment approval, the redundant run also costs an approval per release.