fix: remove doubled ? in missing-argument hint - #6137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a function value is used where a value was expected, the compiler adds a hint built from
format!("Argument might be missing {to_what}?"). The named branch producesto_what = "to function std.group", which reads correctly. The fallback branch — used when the function type carries no name hint — already ended in?, so the two combined into a doubled??:Dropping the
?from the fallback string leaves the one supplied by theformat!. No existing snapshot covered this branch, so a test is added alongside the fix. Found during the nightly survey ofprqlc/prqlc/src/semantic/resolver/.