refine: remove dead commented-out code in window transform resolver - #6097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during the nightly code-quality survey of
semantic/resolver/transforms.rs.The
windowtransform arm carried two commented-out lines that are superseded by theRange { start, end }construction immediately below them:Besides being dead, the commented-out version is now actively misleading: it maps
NonetoLiteral::Nullviamap_or, whereas the live code mapsNonetoNone(an absent bound) viamap. A future reader comparing the two could reasonably thinkNullwas the intended behavior. Removing the stale comment.No behavioral change — the lines were never compiled. No regression test is applicable since nothing executable changed; verified with
cargo build -p prqlcand the existingsql::gen_query::test::test_filter_windowedwindow test, both green.