Skip to content

fix: remove stray f-string sub-rule that mis-highlights PRQL f-strings #6095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-sixty merged 1 commit into from
Jul 22, 2026
Merged

fix: remove stray f-string sub-rule that mis-highlights PRQL f-strings #6095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions web/book/highlight-prql.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,6 @@ Website: https://prql-lang.org/

// Inspired by [Pest's book](https://github.com/pest-parser/book)

// mdBook exposes a minified version of highlight.js, so the language
// definition objects below have abbreviated property names:
// "b" => begin
// "e" => end
// "c" => contains
// "k" => keywords
// "cN" => className

// TODO:
// - Can we represent strings with the actual rule of >= 3 quotes?
// - Aliases seem a bit strong?
Expand Down Expand Up @@ -209,12 +201,6 @@ const formatting = function (hljs) {
],
contains: [
CHAR_ESCAPE,
{
scope: "variable",
begin: "f",
end: '"',
// excludesEnd: true,
},
// TODO: would be nice to have this be a different color, but I don't
// think it's possible to have a subscope within the begin / end.
// {
Expand Down
6 changes: 0 additions & 6 deletions web/website/themes/prql-theme/static/plugins/highlight/prql.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,12 +197,6 @@ const formatting = function (hljs) {
],
contains: [
CHAR_ESCAPE,
{
scope: "variable",
begin: "f",
end: '"',
// excludesEnd: true,
},
// TODO: would be nice to have this be a different color, but I don't
// think it's possible to have a subscope within the begin / end.
// {
Expand Down
Loading