docs: correct RqToSql <returns> to SQL, not JSON - #6094
Merged
Conversation
vanillajonathan
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly survey finding.
RqToSqlcompiles an RQ AST into an SQL string — the<summary>says so and the method returns SQL — but its<returns>XML doc readJSON., copy-pasted fromPrqlToPl/PlToRq(which genuinely return JSON). IntelliSense showed the wrong return type to consumers of the .NET binding.This is a pure documentation-comment change (inside
///), so there's no runtime behavior to test.