Skip to content

chore: bump notify from 7.0.0 to 8.2.0 - #5374

Merged
max-sixty merged 1 commit into
mainfrom
dependabot/cargo/notify-8.2.0
Aug 9, 2026
Merged

chore: bump notify from 7.0.0 to 8.2.0#5374
max-sixty merged 1 commit into
mainfrom
dependabot/cargo/notify-8.2.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bumps notify from 7.0.0 to 8.2.0.

Release notes

Sourced from notify's releases.

notify-8.2.0

notify 8.2.0 (2025-08-03)

  • FEATURE: notify user if inotify's max_user_watches has been reached #698
  • FIX: INotifyWatcher ignore events with unknown watch descriptors (instead of EventMask::Q_OVERFLOW) #700

#698: notify-rs/notify#698 #700: notify-rs/notify#700

debouncer-full 0.6.0 (2025-08-03)

  • FEATURE: allow FileIdCache trait implementations to choose ownership of the returned file-ids #664
  • FEATURE: added support for the flume crate #680
  • FIX: skip all Modify events right after a Create event, unless it's a rename event #701

#664: notify-rs/notify#664 #680: notify-rs/notify#680 #701: notify-rs/notify#701

debouncer-mini 0.7.0 (2025-08-03)

  • FEATURE: added support for the flume crate #680

file-id 0.2.3 (2025-08-03)

  • CHANGE: implement AsRef<FileId> for FileId #664

Full Changelog: notify-rs/notify@notify-8.1.0...notify-8.2.0

notify v8.1.0

What's Changed

New Contributors

... (truncated)

Changelog

Sourced from notify's changelog.

notify 8.2.0 (2025-08-03)

  • FEATURE: notify user if inotify's max_user_watches has been reached #698
  • FIX: INotifyWatcher ignore events with unknown watch descriptors (instead of EventMask::Q_OVERFLOW) #700

#698: notify-rs/notify#698 #700: notify-rs/notify#700

debouncer-full 0.6.0 (2025-08-03)

  • FEATURE: allow FileIdCache trait implementations to choose ownership of the returned file-ids #664
  • FEATURE: added support for the flume crate #680
  • FIX: skip all Modify events right after a Create event, unless it's a rename event #701

#664: notify-rs/notify#664 #680: notify-rs/notify#680 #701: notify-rs/notify#701

debouncer-mini 0.7.0 (2025-08-03)

  • FEATURE: added support for the flume crate #680

file-id 0.2.3 (2025-08-03)

  • CHANGE: implement AsRef<FileId> for FileId #664

notify 8.1.0 (2025-07-03)

  • FEATURE: added support for the flume crate
  • FIX: kqueue-backend: do not double unwatch top-level directory when recursively unwatching #683
  • FIX: Return the crate error PathNotFound instead bubbling up the std::io error #685
  • FIX: fix server hangs when trashing folders on Windows #674

notify 8.0.0 (2025-01-10)

  • CHANGE: update notify-types to version 2.0.0
  • CHANGE: raise MSRV to 1.77 breaking
  • FEATURE: add config option to disable following symbolic links #635
  • FIX: unaligned access to FILE_NOTIFY_INFORMATION #647 breaking

#635: notify-rs/notify#635 #647: notify-rs/notify#647

notify-types 2.0.0 (2025-01-10)

  • CHANGE: replace instant crate with web-time #652 breaking
  • CHANGE: the web-time dependency is now behind the web-time feature breaking

#652: notify-rs/notify#652

debouncer-mini 0.6.0 (2025-01-10)

  • CHANGE: update notify to version 8.0.0

debouncer-full 0.5.0 (2025-01-10)

... (truncated)

Commits
  • a1d7c2d Prepare release (#706)
  • c685ea7 Skip all Modify events right after a Create event, unless it's a rename e...
  • e36d54e fix: INotifyWatcher may raise events with no paths (#700)
  • 394ef18 feat(inotify): notify a user if the max_user_watches has been reached impli...
  • 04473de chore: Prepare 8.1.0 release (#697)
  • 12a026d fix: make PathsMut::commit consuming (#695)
  • d824023 feat: introduce Watcher::paths_mut for adding/removing paths in batch (#692)
  • b984134 Do not clone paths while walking dirs (#693)
  • 416ba82 chore: Use MSRV for Clippy and rustfmt (#694)
  • 10ce3ef Update windows-sys to v0.60 (#691)
  • Additional commits viewable in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
notify [>= 8.0.a, < 8.1]

@dependabot dependabot Bot added dependencies rust Pull requests that update Rust code labels Aug 4, 2025
@dependabot dependabot Bot mentioned this pull request Aug 4, 2025
Closed
@prql-bot
prql-bot enabled auto-merge (squash) August 4, 2025 23:39
@snth

snth commented Mar 27, 2026

Copy link
Copy Markdown
Member

@dependabot rebase

@dependabot @github

dependabot Bot commented on behalf of github Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@prql-bot prql-bot mentioned this pull request May 4, 2026
Closed
@prql-bot

prql-bot commented May 17, 2026

Copy link
Copy Markdown
Collaborator

Skipping automated approval — this is a major version bump (notify 7.0 → 8.2) and test-msrv is failing (log), reporting incompatibility with the repo's MSRV 1.75.0. Needs maintainer review for both the major bump and the MSRV implications.

@prql-bot prql-bot mentioned this pull request May 18, 2026
Closed
max-sixty added a commit to max-sixty/tend that referenced this pull request May 26, 2026
@max-sixty
skills(nightly): trigger upstream-bot rebases instead of manual resol…
0fa16af 
…ution (#605)

## Summary

Step 3 of the nightly skill only looked for conflicted PRs authored by
`$BOT_LOGIN`, so Dependabot/Renovate PRs left in `CONFLICTING` after the
bot stopped rebasing (typically lockfile rewrites on `main` that the
bump also touched) sat untouched forever.

This change extends Step 3 to also query `app/dependabot` and
`app/renovate`. For each upstream-bot PR, after confirming the branch
carries no human commits, the nightly run triggers the bot's own rebuild
path rather than rebasing manually — the bot owns the branch and
force-pushes, so a manual rebase would be discarded:

- `dependabot[bot]` → post `@dependabot recreate` as a comment
- `renovate[bot]` → edit the PR body to tick `[x] <!-- rebase-check -->`
(Renovate has no comment-based rebase command)

`pre-commit-ci[bot]` is intentionally not included — it has no
recreate/rebase mechanism; conflicted autoupdate PRs get superseded by
the next weekly run.

Inline note flags the `app/dependabot` (PR `--author` slug) vs
`dependabot[bot]` (commit-author login) discrepancy so the
no-human-commits check doesn't false-positive on the bot's own commits.

## Test plan

- [ ] Next PRQL nightly picks up `PRQL/prql#5374` (notify),
`PRQL/prql#5543` (ariadne), `PRQL/pyprql#632` and posts `@dependabot
recreate` on each
- [ ] Dependabot rebuilds the branches and the PRs go from `DIRTY` to
`CLEAN`
@prql-bot prql-bot mentioned this pull request Jun 1, 2026
Closed
@prql-bot prql-bot mentioned this pull request Jul 2, 2026
Closed
This was referenced Aug 1, 2026
Open
Open
@prql-bot

prql-bot commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Revisiting this in weekly maintenance — my earlier comment's blocker is stale, and the red CI shown here isn't current signal.

The MSRV objection no longer applies as stated. When I wrote that comment the repo's rust-version was 1.75.0; it moved to 1.81.0 two days later in #5921 (b11de3d5, 2026-05-19) and is still 1.81.0 today. notify 8.2.0 declares rust-version = "1.77" on crates.io, so the declared floor is now under the repo's. That's the declared floor only — test-msrv resolves the whole lockfile, and a transitive crate can push the effective floor higher (that's exactly what sank #6132, where hashbrown 0.17 needs 1.85). So this isn't "unblocked", it's "the recorded reason is no longer the reason".

The test-msrv failure on this PR is from run 17593649647 in September 2025, against a lockfile and an MSRV that no longer exist. The branch has since gone CONFLICTING, and Dependabot won't rebase it because of the two Merge branch 'main' commits from @max-sixty. So there's no way to get a current answer without recreating it.

Requesting a recreate below to get a fresh lockfile against current main and real CI. This is still a major bump (7.0 → 8.2), so I'm not auto-approving it either way — recreating just replaces year-old red with a result worth reading. The only thing overwritten is those two stale merge commits.

@prql-bot

prql-bot commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

@dependabot recreate

@dependabot
chore: bump notify from 7.0.0 to 8.2.0
a713c8a 
Bumps [notify](https://github.com/notify-rs/notify) from 7.0.0 to 8.2.0.
- [Release notes](https://github.com/notify-rs/notify/releases)
- [Changelog](https://github.com/notify-rs/notify/blob/notify-8.2.0/CHANGELOG.md)
- [Commits](notify-rs/notify@notify-7.0.0...notify-8.2.0)

---
updated-dependencies:
- dependency-name: notify
  dependency-version: 8.2.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/cargo/notify-8.2.0 branch from c0b125a to a713c8a Compare August 9, 2026 09:34
prql-bot
prql-bot approved these changes Aug 9, 2026
View reviewed changes

@prql-bot prql-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recreate did what it needed to: fresh lockfile against current main, and the full matrix is green — including test-msrv, which was the blocker in my first comment.

Checked the major bump rather than taking green CI at face value. notify 8.0's only breaking changes are the MSRV raise to 1.77 (notify 8.2.0 declares rust-version = "1.77"; this repo is at 1.81.0) and a Windows FILE_NOTIFY_INFORMATION unaligned-access fix; 8.1/8.2 are fixes and a flume channel feature. Nothing in the surface prqlc/prqlc/src/cli/watch.rs uses changed — RecommendedWatcher::new(tx, Config::default()), Watcher::watch, and the exhaustive EventKind match all still compile without a wildcard arm, so notify-types 2.0 added no variants. That bump also drops the unmaintained instant crate from the tree, which is a small win for cargo-audit.

One caveat for the merge decision: prqlc watch has no test coverage, so green CI proves the bump compiles and breaks nothing else — not that the watcher still behaves at runtime. Given the scope (one optional CLI subcommand) that seems like acceptable risk, but it is not something CI checked.

CI note — first-pass red was a flake

test-rust (x86_64-unknown-linux-gnu, ubuntu-24.04, default,test-dbs-external) failed on the first pass with Error: Timed out waiting for: tcp:1433 — the MSSQL service container did not accept connections inside the 60s wait-on window. No test ran; unrelated to this bump. The tests workflow is green on recent main commits, so it is not a standing failure. I re-ran the failed job (job 93229101360) and it passed; check-ok-to-merge is now green.

@max-sixty
max-sixty merged commit 4d5833f into main Aug 9, 2026
154 of 156 checks passed
@max-sixty
max-sixty deleted the dependabot/cargo/notify-8.2.0 branch August 9, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prql-bot prql-bot prql-bot approved these changes

Assignees

No one assigned

Labels

dependencies rust Pull requests that update Rust code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@snth @prql-bot @max-sixty