Skip to content

chore(terraform): modernize Terraform and provider versions - #5

Merged
JoshLuedeman merged 6 commits into
mainfrom
chore/modernize-terraform-versions
Mar 26, 2026
Merged

chore(terraform): modernize Terraform and provider versions#5
JoshLuedeman merged 6 commits into
mainfrom
chore/modernize-terraform-versions

Conversation

@JoshLuedeman

@JoshLuedeman JoshLuedeman commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Describe your changes

Modernize Terraform and provider version constraints for customer adoption.

  • versions.tf: Update required_version from >= 1.3 to >= 1.9
  • versions.tf: Update azurerm provider from ~> 3.22 to ~> 3.116
  • examples/*/versions.tf: Add terraform {} block with matching version constraints to all 4 examples
  • .github/agents/: Fill in CUSTOMIZE placeholders with project tech stack
  • README.md: Fix Terraform badge version (was >= 1.5, now correctly reflects >= 1.9)
  • CHANGELOG.md: Add [Unreleased] section documenting the version constraint changes

Issue number

#4

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!


⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.

JoshLuedeman and others added 4 commits March 24, 2026 19:14
Generated by 'teamwork init' — adds project orchestration config
and seed memory files for structured project memory.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Update required_version from >= 1.3 to >= 1.9
- Update azurerm provider from ~> 3.22 to ~> 3.116
- Add terraform{} block with version constraints to all 4 example versions.tf
- All validation passes: terraform fmt, terraform validate, all examples

Closes #4

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update agent Project Knowledge sections and README TF_DOCS block
to reflect the new azurerm ~>3.116 and Terraform >=1.9 constraints.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@JoshLuedeman
JoshLuedeman requested a review from Copilot March 24, 2026 23:39
@JoshLuedeman

Copy link
Copy Markdown
Contributor Author

@copilot review this PR

Copilot AI commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

@copilot review this PR

Reviewed. The Terraform and provider version bumps in versions.tf and all four example versions.tf files are correct and consistent. One issue was found and fixed (673734b):

  • README badge inconsistency: The Terraform badge in README.md line 6 still referenced >= 1.5 while the requirements table and versions.tf both reflected >= 1.9. Updated the badge to >= 1.9.
  • CHANGELOG not updated: Added an [Unreleased] entry documenting the version constraint changes.

Everything else looks good — terraform fmt formatting, provider source/version alignment across root module and examples, and README requirements table are all consistent.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the module’s Terraform and provider version constraints to align with current AzureRM releases and ensures the example configurations declare matching minimum versions. It also updates Teamwork agent metadata/config to reflect the repository’s actual tech stack and workflow tooling.

Changes:

  • Bump root module constraints to Terraform >= 1.9 and azurerm ~> 3.116.
  • Add terraform { required_version / required_providers } blocks to all four examples.
  • Fill in .github/agents/*.agent.md CUSTOMIZE placeholders and add .teamwork/config.yaml for Teamwork orchestration.

Reviewed changes

Copilot reviewed 25 out of 30 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
versions.tf Updates module-wide Terraform and provider version constraints.
examples/Commerical/default_w_vnet_integration_public_ip/versions.tf Adds Terraform + provider constraints to the example root config.
examples/Commerical/default_w_vnet_integration_private_ip/versions.tf Adds Terraform + provider constraints to the example root config.
examples/Commerical/default/versions.tf Adds Terraform + provider constraints to the example root config.
examples/Commerical/complete/versions.tf Adds Terraform + provider constraints to the example root config.
README.md Updates generated requirements/providers tables to reflect new versions.
.teamwork/config.yaml Introduces Teamwork orchestration settings (roles, gates, model tiers, MCP servers).
.teamwork/memory/patterns.yaml Adds structured memory placeholder file.
.teamwork/memory/index.yaml Adds structured memory index placeholder file.
.teamwork/memory/feedback.yaml Adds structured memory placeholder file.
.teamwork/memory/decisions.yaml Adds structured memory placeholder file.
.teamwork/memory/antipatterns.yaml Adds structured memory placeholder file.
.github/agents/triager.agent.md Customizes triage taxonomy and workflows for this repo.
.github/agents/tester.agent.md Documents Terraform/Go test commands and stack details.
.github/agents/security-auditor.agent.md Documents stack + test command for security review workflows.
.github/agents/reviewer.agent.md Documents stack + test command for PR review workflows.
.github/agents/refactorer.agent.md Documents lint/test tooling for refactor workflows.
.github/agents/qa-lead.agent.md Documents tech stack for QA oversight workflows.
.github/agents/product-owner.agent.md Documents tech stack for product ownership context.
.github/agents/planner.agent.md Documents stack/languages for planning workflows.
.github/agents/orchestrator.agent.md Documents tech stack for workflow orchestration context.
.github/agents/lint-agent.agent.md Documents formatting/lint commands used for Terraform.
.github/agents/documenter.agent.md Documents MkDocs commands and doc stack context.
.github/agents/devops.agent.md Documents CI/CD platform and Terraform validation/plan approach.
.github/agents/dependency-manager.agent.md Documents dependency sources and update/audit practices.
.github/agents/dba-agent.agent.md Marks DB concerns as N/A for this Terraform module repo.
.github/agents/coder.agent.md Documents stack + build/test/lint commands for implementation work.
.github/agents/architect.agent.md Documents stack/languages for architecture workflows.
.github/agents/api-agent.agent.md Marks API concerns as N/A for this Terraform module repo.

Comment thread README.md
Comment on lines 105 to +109
| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.3 |
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.9 |
| <a name="requirement_azurenoopsutils"></a> [azurenoopsutils](#requirement\_azurenoopsutils) | ~> 1.0.4 |
| <a name="requirement_azurerm"></a> [azurerm](#requirement\_azurerm) | ~> 3.22 |
| <a name="requirement_azurerm"></a> [azurerm](#requirement\_azurerm) | ~> 3.116 |

Copilot AI Mar 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README's terraform-docs tables were updated to Terraform >= 1.9 / azurerm ~> 3.116, but docs/index.md still contains the old generated tables (Terraform >= 1.3 / azurerm ~> 3.22). Please regenerate/update the docs site page as well so published docs and README stay consistent.

Copilot uses AI. Check for mistakes.
Comment on lines +16 to +17
- **Lockfile:** `test/go.sum`, `.terraform.lock.hcl`
- **Audit Command:** `cd test && go list -m all | nancy sleuth`, `tfsec .`

Copilot AI Mar 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This agent doc lists nancy sleuth and tfsec as audit commands and references .terraform.lock.hcl as a lockfile, but neither tool appears to be configured/used in this repo and the lockfile is gitignored (not present in the repo). Please update these entries to the actual audit tooling used here (or remove them) to avoid misleading future dependency update work.

Suggested change
- **Lockfile:** `test/go.sum`, `.terraform.lock.hcl`
- **Audit Command:** `cd test && go list -m all | nancy sleuth`, `tfsec .`
- **Lockfile:** `test/go.sum`
- **Audit Command:** _No dedicated dependency audit command is configured in this repo; use language-specific tooling and CI._

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@JoshLuedeman
JoshLuedeman merged commit e3a59bd into main Mar 26, 2026
3 checks passed
@JoshLuedeman
JoshLuedeman deleted the chore/modernize-terraform-versions branch March 26, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants