Skip to content

Improve synchronization: cancellation & progress management - #177

Merged
paul-fresquet merged 11 commits into
masterfrom
feat/improve-synchronization-1608
Aug 16, 2025
Merged

paul-fresquet merged 11 commits into
masterfrom
feat/improve-synchronization-1608

Conversation

@paul-fresquet

@paul-fresquet paul-fresquet commented Aug 16, 2025

Copy link
Copy Markdown
Contributor

This pull request introduces support for cancellation in the synchronization process, refactors synchronization action handling to propagate cancellation tokens, and improves the reliability of waiting for synchronization data transmission. It also updates resource files for clearer abort messaging and makes minor improvements to debug data source creation.

Synchronization cancellation support

  • Added a CancellationTokenSource property to SynchronizationProcessData, with logic to reset and request synchronization abort. This enables the synchronization process to be cancelled gracefully. [1] [2] [3]
  • Refactored ISynchronizationActionHandler and its implementation to accept and propagate CancellationToken parameters, ensuring that all synchronization actions can be cancelled. [1] [2] [3] [4] [5]

Reliable synchronization data transmission waiting

  • Enhanced ReactiveUtils.WaitUntilTrue to support cancellation and proper timeout handling, including overloads with CancellationToken.
  • Updated synchronization progress and transfer handlers to use these new methods, ensuring they respect cancellation and timeouts when waiting for synchronization data transmission. [1] [2]

Resource and messaging improvements

  • Added new resource entries for abort actions in both French and English resource files for clearer UI messaging. [1] [2]

Debug/test data source improvements

  • Changed the debug data source creation logic to use a user profile-based test folder instead of the desktop, improving test isolation. [1] [2]

Minor code cleanup

  • Removed unused using directives from several service and receiver files for clarity. [1] [2] [3] [4] [5] [6]

@sonarqubecloud

sonarqubecloud Bot commented Aug 16, 2025

Copy link
Copy Markdown

@paul-fresquet
paul-fresquet merged commit 564e0e5 into master Aug 16, 2025
24 checks passed
@paul-fresquet
paul-fresquet deleted the feat/improve-synchronization-1608 branch August 16, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant