Sync: guest operations, runtime hardening, and docs consolidation - #1
Merged
Conversation
EnsureRoute ran `ip route replace` via ExecInNode but only checked the Go error from launching the process, not its exit code. When the guest lacked iproute2 (or the command otherwise failed), the shell exec itself succeeded so `err` was nil, and the missing/failed route was silently swallowed — nodes ended up with no default route and no diagnostic pointing at why. Mirrors the libvirt provider's EnsureRoute, which already checked ExitCode. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jiandong01
pushed a commit
that referenced
this pull request
Aug 31, 2026
…a migrations once' (#1) from fix/api-postgres-connection-pool into main Reviewed-on: https://git.pku.edu.cn/oslab/sysbox/pulls/1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sync
mainwith the internal repo (24 commits since78cbb30). Highlights:🤖 Generated with Claude Code